Fix Tree.Prototype.entryById and .getEntry #1731
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* entryById now follows pattern of entryByName and entryByIndex where the parent property is added to the entry. * entryByPath renamed to _entryByPath since getEntry should be used instead. * Simple test for entryById added. * Setup of commits used in test for TreeEntry.walk moved to test setup so getEntry can test searching by path as well. * Tests using Tree.prototype.entryByPath now use Tree.prototype.getEntry.
miachenmtl
force-pushed
the
tree-entry-methods
branch
from
409ebb3
to
bd3f48c
Compare
miachenmtl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experiencing a bug where
Entry.prototype.path()was not working when a tree entry was fetched using Tree.prototype.entryById. This PR should resolve the bug. I also noticed that entryByPath had the same problem, but in this case, getEntry adds the necessary properties, so I renamed entryByPath to _entryByPath following the same pattern as entryByName and _entryByName.