Fix Alloc-Dealloc mismatches #1943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (uint32_t i = 0; i < tempArray->Length(); ++i) { | ||
| auto conversionResult = Configurable{{ arg.arrayElementCppClassName }}::fromJavascript( | ||
| nodegitContext, | ||
| Nan::Get(tempArray, i).ToLocalChecked() | ||
| ); | ||
|
|
||
| if (!conversionResult.result) { | ||
| delete[] baton->{{ arg.name }}; | ||
| // TODO free previously allocated memory |
There was a problem hiding this comment.
Does this still need to be handled?
There was a problem hiding this comment.
@julianmesa-gitkraken this comment came from you.
There was a problem hiding this comment.
Yes but I will do it in another PR. I need to store all allocated memory in a map, then if I get an error reading javascript arguments we have to release all allocated memory, then throw the error.
zawata
force-pushed
the
fix/alloc-dealloc-mismatch
branch
from
42da6a6
to
af08eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Alloc-Dealloc Mismatch causes undefined behavior. Kind of a minor problem but should be fixed nonetheless.
for more details
https://stackoverflow.com/a/10854437/4776273