Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks #1944

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Fix memory leaks #1944

wants to merge 18 commits into from

Conversation

julianmesa-gitkraken
Copy link
Contributor

Fix memory leaks

@julianmesa-gitkraken julianmesa-gitkraken force-pushed the fix-memory-leaks branch 2 times, most recently from 4fcce07 to a24d5f8 Compare October 19, 2022 10:56
@julianmesa-gitkraken
Fix leak
6c4e32d 
 We need to free duplicated memory we are responsible for that we obtained from libgit2 because nodegit duplicates it again when calling the wrapper
@julianmesa-gitkraken julianmesa-gitkraken changed the title Fix memory leaks [WIP] Fix memory leaks Oct 25, 2022
@julianmesa-gitkraken julianmesa-gitkraken marked this pull request as draft October 25, 2022 14:25
@julianmesa-gitkraken julianmesa-gitkraken changed the title [WIP] Fix memory leaks Fix memory leaks Nov 9, 2022
@julianmesa-gitkraken julianmesa-gitkraken marked this pull request as ready for review November 9, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@julianmesa-gitkraken