Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commit_create_cb #1946

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix commit_create_cb #1946

wants to merge 1 commit into from
+48 −52

Conversation

julianmesa-gitkraken
Copy link
Contributor

The definition was wrong parents should be an array of Commits not Oids.
Also we are copying the Oid in the callback so we are not returning the Oid so we must not set selfFreeing to false.

@julianmesa-gitkraken julianmesa-gitkraken marked this pull request as ready for review October 27, 2022 17:15
@julianmesa-gitkraken
Fix commit_create_cb
0a3ab68 
The definition was wrong parents should be an array of Commits not Oids.
Also we are copying the Oid in the callback so we are not returning the Oid so we must not set selfFreeing to false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@julianmesa-gitkraken