Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: delay maintenance date for v12.x by 1 month #618

Merged
merged 1 commit into from Oct 12, 2020

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Oct 9, 2020

Opening this as discussed in the Release WG meeting (#615) and (#616).

This PR moves the maintenance start date for Node.js 12 from 2020-10-20 to 2020-11-30. This means that Node.js 12 will stay in Active LTS for an additional month.

Note that I think this against our policy, as we're changing it with less than 14 days notice.
I think in the meeting we assumed maintenance was due to start at the end of the month, but when opening the PR I realised it was listed as 2020-10-20.

The exact date that a release will be moved to LTS, moved between LTS modes, or deprecated will be chosen no later than the first day of the month it is to change. If the release team plans to change the release date, it will be done with no less than 14 days notice.

@nodejs/release please review.

(plus a courtesy ping to @nodejs/tsc)

@mmarchini
Copy link

mmarchini commented Oct 9, 2020

what's the tl;dr for pushing the maintenance start date to november? (delaying sgtm, I'm just curious :) )

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau
Copy link
Member

what's the tl;dr for pushing the maintenance start date to november? (delaying sgtm, I'm just curious :) )

The modules team want to get some semver-minor changes into 12 before it goes into maintenance that were not ready to go out in 12.19.0 (having only landed in current last week).

Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Trott
Copy link
Member

Trott commented Oct 9, 2020

I don't have a problem with this, but if anyone does and wants to be a stickler about not violating the 14-day thing, the Release team (although the text needs to be updated, I think) can decide that semver-minor stuff can land in a Maintenance release if the situation warrants it:

Maintenance - Critical bug fixes and security updates. New features may be added at the discretion of the LTS team

(Emphasis added.)

Another way around it would be to change the 14-day policy. :-D

@MylesBorins
Copy link
Member

@Trott it as a originally brought up in #616 4 days ago. We also had a date of the 27th of october listed for the semver minor is the release issue for over a month. We didn't update the JSON, but I think the intent and timeline here is clear enough since we have had amply public discussion.

Screen Shot 2020-10-09 at 11 10 21 PM

If I recall historically we had the 14 day rule because people were upset at a last minute change of EOL for Node.js 4 or 6. I think keeping something is reasonable, without that rule I don't think we would have talked about this change so early.

@Trott
Copy link
Member

Trott commented Oct 10, 2020

@MylesBorins Yes, it's all good by me and I probably shouldn't have said anything in the first place. Carry on!

@BethGriggs BethGriggs merged commit c4f4b64 into nodejs:master Oct 12, 2020
@lpinca
Copy link
Member

lpinca commented Oct 12, 2020

I think it makes sense also to explore the possibility to backport the EventTarget stuff as per nodejs/node#33556 (comment).

Refs: websockets/ws#1795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants