Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce inactive collaborator duration #1540

Merged
merged 23 commits into from May 7, 2024
Merged

Reduce inactive collaborator duration #1540

merged 23 commits into from May 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 26, 2024 •
edited by aduh95

Currently, the bot looks through all commits on main that have landed in the last 12 months, and makes two lists:

  • a list of all the commit authors.
  • a list of all the collaborators who are listed as reviewers in the commit message (i.e. folks who have approved the PR).

The bot will open a PR to move a collaborator to emeritus if they don't appear in either of those lists.
This vote is to decide whether we want to reduce the timespan from 12 months to
9 months.

Vote instructions:

To close the vote, at least 3 secret holder(s)1 must run the following command: git node vote https://github.com/nodejs/TSC/pull/1540 --decrypt-key-part --post-comment (N.B.: you should not add the --post-comment flag if the token you're using does not have permission to post comments)

/cc @nodejs/tsc

Current estimated participation: 100%

Footnotes

  1. secret holders are folks who have access to the private key associated with a public key on hkps://keys.openpgp.org that references an email address listed on the TSC voting member list at the time of the opening of the vote. ↩

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@RafaelGSS

This comment was marked as resolved.

Sign in to view
@RafaelGSS RafaelGSS force-pushed the votes/1415d109-3ebc-4ee8-b3c3-a3b2a62ea033 branch from 03cddec to ffd5b7a Compare April 28, 2024 19:26
@gireeshpunathil

This comment was marked as resolved.

Sign in to view
@anonrig
Copy link
Member

anonrig commented Apr 29, 2024

@aduh95 FYI The GPG I use on Github is with different email, and voting doesn't work because my email address is Sentry's in the TSC list. Additionally, lack of core.editor on Git config crashes the voting.

@anonrig

This comment was marked as resolved.

Sign in to view
@joyeecheung
Copy link
Member

joyeecheung commented Apr 30, 2024 •
edited

I voted from GitHub code spaces so it's unverified (I was just curious how am I supposed to use code spaces to push to a PR)

@jasnell
Copy link
Member

jasnell commented Apr 30, 2024

I think I voted correctly

@richardlau

This comment was marked as resolved.

Sign in to view
@aduh95
Copy link
Contributor

aduh95 commented Apr 30, 2024

I think I voted correctly

FWIW the bot also thinks you voted correctly – otherwise it would show a red cross instead of a green tick next to your commit (and it would have posted a comment to notify you why the commit is rejected). I say think because it can't tell whether the encrypted data in your commit is valid YAML syntax.

@mcollina

This comment was marked as resolved.

Sign in to view
@GeoffreyBooth
Copy link
Member

The command line didn’t work for me either but I was able to vote via the web: https://nodejs.github.io/caritat/#https://github.com/nodejs/TSC/pull/1540

@aduh95
Copy link
Contributor

aduh95 commented May 4, 2024

I would like to close this vote, and for this effect, I'm revealing my key part:

-----BEGIN SHAMIR KEY PART-----
j0/wS4x6g3kkocvc59kPw/b7op+B2Xsx0GK7Oo9pITIB
-----END SHAMIR KEY PART-----

@targos
Copy link
Member

targos commented May 5, 2024

I would like to close this vote, and for this effect, I'm revealing my key part:

-----BEGIN SHAMIR KEY PART-----
jihJsg9qYSP92DW+a3AWV6+RN1TY8wNRagY8zea0gTET
-----END SHAMIR KEY PART-----

@aduh95
Copy link
Contributor

aduh95 commented May 6, 2024

@mcollina, @RafaelGSS, @richardlau: can one of you reveal his key part so the ballots can be decrypted?

@richardlau
Copy link
Member

I would like to close this vote, and for this effect, I'm revealing my key part:

-----BEGIN SHAMIR KEY PART-----
npeJt04f0dYDni3+v5W6XtMDAUVDDbXN03y6a55d8T8P
-----END SHAMIR KEY PART-----

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 7, 2024

Election results

Subject: Reduce inactive collaborator duration
End date: 2024-05-07T13:48:14.258Z
Participation: 100%

Results

Winning candidate: Status quo: Keep the current inactive collaborator duration of 12 months

Table of results

Candidate Number of won duels
Status quo: Keep the current inactive collaborator duration of 12 months 1
Reduce the inactive collaborator duration to 9 months 0

Voting data

Participants:

Private key to decrypt ballots 
-----BEGIN PRIVATE KEY-----
MIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQDAizdQVs4HfqzK
K8SV9JgkQyWO+qMEZmPPfT5kORT4tHdFnecToJ+h/KLWHdLFjGbyGsh6cWDC229l
zC+Rp9o1MfFdJTpMqqBfhMwppD07pPVl5hclHI332dfgZS660nPrKRX/Yj1m8wru
BkKghOAcBm8h4sEKwNxpDQ3SykIn2icKZTprdm7cbueHFuAsdXBmhqN6GR4nQwoT
Yxtk8RXxkytlOUuCsihn07OlWnSUP5lIj178VM3jmYMMpY10EHJFUk/AKwEd6zAf
w3pusTQreGiwVFL2/1YHfDZfnbD0mjBmnjYrl1EFXgLWGFnfh/XZrquzqVNEt0fT
dX0tBGeNAgMBAAECggEAIwszjhO+e+66VDGTHhfeePsfot5LPUnFcMZCzMr23i06
aBlNLW1WoIzytjXHXt0m/3mQc3ifO9fkdoqrPb9nH7dvTpyv97Q2bCwnXIzf+DMV
1u4B2GdSD4I+oEDKOIaFQo+/yTOAKXSi0J+jEMQeZftlzq0OpX5kn1oY4fyd/dKN
mj/W5ERYGodXaVx1dlB3CCpk7Az639PW1R1lveVOtANM4n40+4is4euaLGWwKGap
iIQVJAG45L4PXL8zMw04wtSLHiIV3WarDABSXcBQBGx6Na294CrgE77w8U360mxt
EwvT9jzkx9Dmrdkf/FpydchyoKtE2KQF3wFWZHdLoQKBgQDyB4YZe19Fwgtjpanu
InYgH/mxb9WSSL/mdcV9+1/TclTdrYGEpSqETGh0+xI/tblW6mGawVjqmOuGcp25
u92+6A6NaWvyCFky+P3ytmiTRkAZ21BV9Ta12h7VQJhvbtHLiumfidlXvw15sDDV
aG3bCDzV2+JZthz1U3lqLHmLJwKBgQDLqHE322ra1WDl54YJ2GviCF2eoPkNkZ6j
rlnnr7naa6B+stgRLDefEnrz+h/Cj2XEXCtpvoczVdzFmTP0SylY4QOWq5/lX3lt
NlLfJ6hPwLlIFvK+CgJPgmAylgeSNiGv5qy2LgADIcr85gmPVhV+ka7HZXjn9cYj
C+9AuHq4KwKBgGKJgaU6P22tNOna9rZHPYSSwBvnhjJKgCaZ6FAEWd1CfR7LlyGk
BQ1b9mM6HRHnMJAcWKSi90p7+9f/LgwCWqNw4wvb0eD2WSqRiQKaFTVwsoRUb/6v
GRkstsTnyagEnFGcOsWDYAODez8B5r/cBm3YirwfC6auqFeRJqt9c/adAoGAI322
RVKym3JGEaq4XCzgGCL3Fbbd0DSJXeL7ffnMvLi23n2SU+PNyaXx0WTMdh6BUKfz
VNlEPHkBIVpiiHc0vG1yL6a3FcT+pz6pUIRbu5JNd7ewE9gwsOR6mTY2GY/fbQUZ
IiKAFAumkU4Ram5JDqaau9r+KAZXwjHJPxEnKcMCgYEA6lwrubJdZobeqSp40YX2
C1Cygu+GnkSbqkZx76qnZuPbC0+qML8RPh+oVni5F9UBCX0qcC/RDmkdjsM/CIy8
+pTkEuPDwPj3+7OjCqDJnSQ1ELMrDJQGhX/GVuSfgaatrlps3ZH6uDy1HRqvyke2
B/0otZOqvd1YzB8lBENLevw=
-----END PRIVATE KEY-----

Footnotes

  1. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  2. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  3. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  4. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  5. Abstained. ↩

  6. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  7. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  8. Voted for Reduce the inactive collaborator duration to 9 months. ↩

  9. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  10. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  11. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  12. Abstained. ↩

  13. Voted for Reduce the inactive collaborator duration to 9 months. ↩

  14. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  15. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  16. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  17. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  18. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  19. Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩

  20. Voted for Reduce the inactive collaborator duration to 9 months. ↩

@anonrig
Copy link
Member

anonrig commented May 7, 2024

@aduh95 Why does some votes have 1 or -1 on them and some of them has 1 or 0?

@aduh95
Copy link
Contributor

aduh95 commented May 7, 2024

@anonrig It's whatever people have voted (Tobias even voted 12 and 9, amusingly enough)

@aduh95 aduh95 merged commit cac20cc into main May 7, 2024
1 check failed
@GeoffreyBooth
Copy link
Member

@anonrig It’s whatever people have voted (Tobias even voted 12 and 9, amusingly enough)

How are such votes calculated? Would it be divided, so Tobias’ vote becomes 9/12 = 0.75 toward whichever option he preferred, rather than 1? Or is it just 12 > 9 so whichever option got 12 gets the full 1 vote?

@aduh95
Copy link
Contributor

aduh95 commented May 7, 2024

@GeoffreyBooth it's the latter, as written on the vote ballot, only the order matters.

@GeoffreyBooth
Copy link
Member

GeoffreyBooth commented May 7, 2024 •
edited

A nice improvement to the bot would be if the results comment could include the number and percentage of votes for each option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet