Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add minutes for meeting 28 Mar 2018 #514

Merged
merged 3 commits into from
Mar 30, 2018
Merged

doc: add minutes for meeting 28 Mar 2018 #514

merged 3 commits into from
Mar 30, 2018

Conversation

fhinkel
Copy link
Member

@fhinkel fhinkel commented Mar 29, 2018

Notes for #513

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


* **Recording**: https://youtu.be/NSVVyXroQL8
* **GitHub Issue**: https://github.com/nodejs/TSC/issues/513
* **Minutes Google Doc**: https://docs.google.com/document/d/1aaJbzIvyhBIINeBcQaWSivar5EqYShU5G9LiEjvDsEs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the doc is world-editable, there's no guarantee that it will remain a useful document. Since everything is in here already, I recommend removing the link.

Feel free to revert, but I think that we shouldn't link the Google doc in the published minutes anymore, and I'm also removing the Moderation Team announcement as we usually leave that in the issue tracker and I'm not sure how much value there is in putting the (intentionally vague) information in the minutes. Again, feel free to revert this one. My opinion only.
@Trott Trott merged commit d7a50c2 into master Mar 30, 2018
@sam-github sam-github deleted the fhinkel-patch-2 branch December 5, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants