Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: add python3 to AIX hosts #2564

Merged
merged 1 commit into from Mar 11, 2021
Merged

Conversation

richardlau
Copy link
Member

I've run this on all of our test/release AIX 7.1 and 7.2 hosts. It installs Python 3 (3.7.9 at this time) into /opt/freeware/bin, e.g. /opt/freeware/bin/python3. Crucially it leaves the existing Python 2 installation alone (so python still runs Python 2).

On the AIX 7.2 machines there is already a Python 3.6.12 installation in /opt/bin/python3. We end up with three versions of Python installed (2.7.18, 3.6.12 and 3.7.9) but they're in different directories and the python3 binary we pick up depends on the path. If we've run through select-compiler.sh and prepend /opt/freeware/bin to the path python3 will be 3.7.9.

export PATH="/opt/ccache-3.7.4/libexec:/opt/freeware/bin:$PATH"

I haven't found a CI job that will actually use Python 3 yet as they either directly call python configure ... (i.e. invoke python which is Python 2) or they run make run-ci which defaults the PYTHON make variable to python (again Python 2). We'll probably need to directly run configure ... (as there is Python autodetection/selection logic in the configure script) and/or set the default PYTHON in the makefile to python3 in master/16.x onwards.

cc @nodejs/platform-aix

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit 7034b89 into nodejs:master Mar 11, 2021
@richardlau
Copy link
Member Author

Refs: #2507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants