Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: build gn from source on Linux PPC/s390x #2675

Merged
merged 1 commit into from Jun 23, 2021

Conversation

richardlau
Copy link
Member

Add build-test-v8 meta-role for installing prerequisites for V8
building/testing. Add roles to build gn and ninja binaries from
source and call those from the build-test-v8 role for Linux on
ppc64/s390x.

This removes a previously manual step from the Linux PPC/s390x setup (docs also updated).

I've deployed this onto

  • test-ibm-rhel7-s390x-1
  • test-ibm-rhel7-s390x-2
  • test-ibm-rhel7-s390x-3
  • test-ibm-rhel7-s390x-4
  • test-osuosl-centos7-ppc64_le-1
  • test-osuosl-centos7-ppc64_le-2

to update the version of gn (the version we'd previously manually compiled is now too old, see nodejs/node#38990 (comment)).
We're now updated to:

[iojs@test-osuosl-centos7-ppc64--le-1 build-tools]$ ./ninja --version
1.10.2
[iojs@test-osuosl-centos7-ppc64--le-1 build-tools]$ ./gn --version
1916 (d2dce75)
[iojs@test-osuosl-centos7-ppc64--le-1 build-tools]$

Add `build-test-v8` meta-role for installing prerequisites for V8
building/testing. Add roles to build `gn` and `ninja` binaries from
source and call those from the `build-test-v8` role for Linux on
ppc64/s390x.
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit 8068343 into nodejs:master Jun 23, 2021
@richardlau richardlau deleted the gn branch June 23, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants