Fixes for Ubuntu 16.04 to fix C++ coverage #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ubuntu 16.04 the `python3-pip` package is not compatible with Python 3.8 and later. Downgrade Python 3 to Python 3.7 which is new enough for building current Node.js (Python 3.6 or later) but still compatible with the `python3-pip` package.
Code coverage runs `gcov` but this needs to match the version of gcc/g++ used.
This was referenced Jul 9, 2021
|
FTR the Ansible changes have been deployed to both benchmark machines
and I've manually As an aside, I view the stuff we've had to juggle with Python 3 on these machines more reason to update them to Ubuntu 20.04 (#2656). |
Trott
approved these changes
Jul 10, 2021
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 11, 2021
Update the version of `gcovr` used for C++ coverage from 3.4 to 4.2 for compatibility with gcc/g++ 8. PR-URL: #39326 Refs: #39303 Refs: gcovr/gcovr#228 Refs: nodejs/build#2705 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 13, 2021
Update the version of `gcovr` used for C++ coverage from 3.4 to 4.2 for compatibility with gcc/g++ 8. PR-URL: #39326 Refs: #39303 Refs: gcovr/gcovr#228 Refs: nodejs/build#2705 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 4, 2021
Update the version of `gcovr` used for C++ coverage from 3.4 to 4.2 for compatibility with gcc/g++ 8. PR-URL: #39326 Refs: #39303 Refs: gcovr/gcovr#228 Refs: nodejs/build#2705 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two build side fixes required together with nodejs/node#39326 to address the currently broken C++ coverage.
ansible: downgrade to Python 3.7 on Ubuntu 16.04
On Ubuntu 16.04 the
python3-pippackage is not compatible withPython 3.8 and later. Downgrade Python 3 to Python 3.7 which is
new enough for building current Node.js (Python 3.6 or later) but
still compatible with the
python3-pippackage.jenkins: set GCOV on Ubuntu to match CC/CXX
Code coverage runs
gcovbut this needs to match the version ofgcc/g++ used.
Refs: nodejs/node#39303
Refs: nodejs/node#39326