jenkins: run ARM64 Windows tests on Node.js >=19 #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Mar 23, 2023
StefanStojanovic
added a commit
to JaneaSystems/node
that referenced
this pull request
Mar 23, 2023
Refs: nodejs#45943 Refs: nodejs#47020 Refs: nodejs/build#3046 Refs: nodejs/build#3246 Refs: nodejs/build#3250 Refs: nodejs/build#3211
targos
approved these changes
Mar 24, 2023
UlisesGascon
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding ARM64 Windows machines to CI and stabilizing the tests, it is time to complete #3046 and enable the tests to run by default.
This PR makes it so, but only for Node.js 19 and above, as the tests are not stable on LTS versions.
This is currently in use in Jenkins. This was applied in https://github.com/nodejs/jenkins-config-test/compare/f94d4652ce4d902263f0967922f6a1482c8a48c4...3133da6f058c16b56e02370500e135c16fb79740 and I will revert the url changes once this lands.
Fixes: #3046