Adding ARM64 Windows MSI to Jenkins #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Mar 24, 2023
richardlau
approved these changes
Mar 24, 2023
UlisesGascon
approved these changes
Mar 25, 2023
Refs: nodejs/node#45943 PR-URL: nodejs#3251 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ulises Gascón <UlisesGascon@users.noreply.github.com>
StefanStojanovic
force-pushed
the
mefi-win-arm64-msi
branch
from
c6570ba
to
1ace7a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of WiX4 PR that implements a runtime detection of the WiX version used for the MSI (required because of the LTS versions). If WiX4 is detected, the MSI for Windows ARM64 is created.
We've created a temporary job for testing these changes before opening PR here. As visible from runs, detection works as expected.
Refs: nodejs/node#45943