Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: add gcc-toolset-10-libatomic-devel on RHEL8 #3252

Merged
merged 1 commit into from Mar 25, 2023

Conversation

richardlau
Copy link
Member

V8 CI requires libatomic.


e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/5239/nodes=rhel8-s390x,v8test=v8test/console

13:42:18 FAILED: torque 
13:42:18 python3 "../../build/toolchain/gcc_link_wrapper.py" --output="./torque" -- g++ -pie -Werror -Wl,--fatal-warnings -Wl,--build-id -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now -m64 -rdynamic -Wl,-z,defs -Wl,--as-needed -pie -Wl,--disable-new-dtags -Wl,-O2 -Wl,--gc-sections -o "./torque" -Wl,--start-group @"./torque.rsp"  -Wl,--end-group  -latomic -ldl -lpthread -lrt
13:42:18 /opt/rh/gcc-toolset-10/root/usr/bin/ld: cannot find -latomic
13:42:18 collect2: error: ld returned 1 exit status

@richardlau
Copy link
Member Author

I've deployed onto the rhel8-s390x and rhel8-ppc64le machines. Test build has revealed we need a V8 backport for gcc-10 which I'll identify and open after this.
e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/5241/nodes=rhel8-s390x,v8test=v8test/console

15:39:58 In file included from ../../test/cctest/compiler/test-operator.cc:8:
15:39:58 ../../src/compiler/operator.h: In function ‘void v8::internal::compiler::TestTestOperator1double_Equals()’:
15:39:58 ../../src/compiler/operator.h:185:23: error: array subscript 6 is outside array bounds of ‘v8::internal::compiler::Operator [1]’ [-Werror=array-bounds]
15:39:58   185 |     return this->pred_(this->parameter(), that->parameter());
15:39:58       |            ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
15:39:58 ../../test/cctest/compiler/test-operator.cc:213:12: note: while referencing ‘op3’
15:39:58   213 |   Operator op3(25, NONE, "Weepy", 0, 0, 0, 0, 0, 0);
15:39:58       |            ^~~

Waiting for the builds currently running on the rhel8-x64 machines to finish before deploying the change there as well (although the V8 CI currently doesn't run on those as the builds take a lot longer than on the benchmark machine (which is currently down)).

@richardlau
Copy link
Member Author

Test build has revealed we need a V8 backport for gcc-10 which I'll identify and open after this.

Backport PR: nodejs/node#47236

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit d428b08 into nodejs:main Mar 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants