Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: pin 7-zip to 22.01 #3712

Merged
merged 1 commit into from May 10, 2024
Merged

Conversation

StefanStojanovic
Copy link
Contributor

Windows ARM64 cross-compiled node.exe cannot be extracted from .7z file on Windows 11 because of the way the latest version of 7-zip (v23.01) packs it. This pins the 7zip and 7zip.install Chocolatey packages to the version that works.

This change is already applied to all machines that do compilation in both release and test CI (VS2019 and VS2022 machines in Rackspace)

Fixes: #3695

Windows ARM64 cross-compiled node.exe cannot be extracted on Windows 11

Fixes: nodejs#3695
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 0caa983 into nodejs:main May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrupted v22.0.0 Windows ARM64 7z file
4 participants