Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver timeout increased for single test #1013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alfonsograziano
Copy link
Contributor

Checklist
  • npm test passes
  • contribution guidelines followed
    here

Even if we increased the overall Semver test suite timeout in #1004, some tests still fail due to timeout.
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3318/nodes=rhel8-ppc64le/testReport/junit/(root)/citgm/semver_v7_5_4/

This change will bring the timeout for the single test to 60s.
I'm not sure if this is a proper solution, but we can give it a shot.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b8193a7) 96.44% compared to head (5af659c) 96.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1013   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          28       28           
  Lines        2139     2139           
=======================================
  Hits         2063     2063           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RafaelGSS
Copy link
Member

RafaelGSS commented Oct 11, 2023

What do you mean by single test? There are at least 3 tests failing due to timeout, is it reproducible in your machine?

@alfonsograziano
Copy link
Contributor Author

I'm sorry for the poor choice of wording :) I mean that the single test failed due to timeout, not the entire citgm run. In fact, the citgm run finished after 3 min and 10 sec (with a 5 min timeout).

It is not reproducible on my machine unfortunately (since I'm using macOS).
Maybe @isaacs can help us?
Sorry for the ping, I see that you are mentioned as the maintainer of this package. Can you please take a look at the timeouts? I'm not sure if the solution I proposed can fix the issue or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants