Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: skip clinic on AIX and Windows #780

Merged
merged 1 commit into from Mar 11, 2020

Conversation

BethGriggs
Copy link
Member

See #779

Using this PR to kick off a test run to see if CITGM on AIX gets further when this module is skipped.

@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #780 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #780   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          27       27           
  Lines         888      888           
=======================================
  Hits          848      848           
  Misses         40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399c78c...b1948d7. Read the comment docs.

@BethGriggs
Copy link
Member Author

Skipping the clinic module on AIX allows the v10.x CITGM runs to complete and publish results
https://ci.nodejs.org/job/citgm-smoker/2210/

@BethGriggs BethGriggs marked this pull request as ready for review January 9, 2020 13:04
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethGriggs BethGriggs changed the title lookup: skip clinic on AIX lookup: skip clinic on AIX and Windows Jan 9, 2020
@MylesBorins MylesBorins merged commit 2d18f4a into nodejs:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants