Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: add yarn to lookup.json #993

Closed
wants to merge 19 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
show-progress: false

- name: Use LTS Node.js
uses: actions/setup-node@v3
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-module.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,18 @@ jobs:
- ubuntu-latest
- windows-latest
node-version:
- 14.x
- 16.x
- 18.x
- 20.x

runs-on: ${{ matrix.os }}

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: ${{ github.event.inputs.repository }}
ref: ${{ github.event.inputs.ref }}
show-progress: false

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
Expand Down
25 changes: 25 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,31 @@ npm install -g nyc

- PRs are welcome!

## CITGM team

<!-- ncu-team-sync.team(nodejs/citgm) -->

* [@BridgeAR](https://github.com/BridgeAR) - Ruben Bridgewater
* [@ljharb](https://github.com/ljharb) - Jordan Harband
* [@lukekarrys](https://github.com/lukekarrys) - Luke Karrys
* [@MylesBorins](https://github.com/MylesBorins) - Myles Borins
* [@richardlau](https://github.com/richardlau) - Richard Lau
* [@targos](https://github.com/targos) - Michaël Zasso

<!-- ncu-team-sync end -->

<details>
<summary>CITGM team emeritus</summary>

* [@al-k21](https://github.com/al-k21) - Oleksandr Kushchak
* [@bengl](https://github.com/bengl) - Bryan English
* [@bzoz](https://github.com/bzoz) - Bartosz Sosnowski
* [@gdams](https://github.com/gdams) - George Adams
* [@gibfahn](https://github.com/gibfahn) - Gibson Fahnestock
* [@jasnell](https://github.com/jasnell) - James M Snell

</details>

## Contributors

- as listed in <https://github.com/nodejs/citgm/blob/HEAD/AUTHORS>
10 changes: 4 additions & 6 deletions lib/bin/citgm-all.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'make-promises-safe';

import * as os from 'os';

import async from 'async';
Expand Down Expand Up @@ -195,7 +193,7 @@ function launch() {

const q = async.queue(runTask, app.parallel || 1);
q.push(collection);
function done() {
function done(exitCode = 0) {
q.kill();
reporter.logger(log, modules);

Expand All @@ -217,17 +215,17 @@ function launch() {
reporter.junit(junit, modules, app.append);
}

process.exit(reporter.util.hasFailures(modules));
const hasFailures = reporter.util.hasFailures(modules) ? 1 : 0;
process.exit(hasFailures || exitCode);
}

function abort() {
q.pause();
q.kill();
process.exitCode = 1;
process.removeListener('SIGINT', abort);
process.removeListener('SIGHUP', abort);
process.removeListener('SIGBREAK', abort);
done();
done(1);
}

q.drain(done);
Expand Down
2 changes: 0 additions & 2 deletions lib/bin/citgm.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'make-promises-safe';

import rootCheck from 'root-check';
import uidnumber from 'uid-number';

Expand Down
5 changes: 1 addition & 4 deletions lib/citgm.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import { createHash } from 'crypto';
import { EventEmitter } from 'events';
import { promisify } from 'util';

import npa from 'npm-package-arg';
import BufferList from 'bl';
import whichLib from 'which';

const which = promisify(whichLib);
import which from 'which';

import { grabModuleData } from './grab-module-data.js';
import { grabProject } from './grab-project.js';
Expand Down
2 changes: 1 addition & 1 deletion lib/grab-module-data.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function grabModuleData(context) {
return;
}

if (data === '') {
if (data === '' || errData?.match(/No match found for version/)) {
reject(
new Error(`No module version found satisfying ${context.module.raw}`)
);
Expand Down