Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support arrow getter in Object.defineProperty #74

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

magic-akari
Copy link

This pull request add support to arrow getter in Object.defineProperty.

Object.defineProperty(exports, 'a', {
    enumerable: true,
    get: function () {
        return q.p;
    }
});

Object.defineProperty(exports, 'b', {
    enumerable: true,
    get() {
        return q.p;
    }
});

Object.defineProperty(exports, 'c', {
    enumerable: true,
    get: () => {
        return q.p;
    }
});

Object.defineProperty(exports, 'd', {
    enumerable: true,
    get: () => q.p,
});

Before this pull request, only a and b are detected.
After this pull request, c and d will also be detected.

@himself65
Copy link
Member

/cc @guybedford

@guybedford
Copy link
Collaborator

@himself65 sorry, but this package is only taking bug fixes, not feature additions at this point, due to backwards compatibility requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants