Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: add watch subsystem #103

Merged
merged 1 commit into from Nov 7, 2022
Merged

rules: add watch subsystem #103

merged 1 commit into from Nov 7, 2022

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Nov 3, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 93.93% // Head: 93.93% // No change to project coverage 👍

Coverage data is based on head (49fb56f) compared to base (fa47c55).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   93.93%   93.93%           
=======================================
  Files          19       19           
  Lines         462      462           
=======================================
  Hits          434      434           
  Misses         28       28           
Impacted Files Coverage Δ
lib/rules/subsystem.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MoLow
Copy link
Member Author

MoLow commented Nov 5, 2022

@nodejs/tsc who can approve this?

@Trott
Copy link
Member

Trott commented Nov 5, 2022

I guess this most impacts @nodejs/releasers?

@Trott
Copy link
Member

Trott commented Nov 5, 2022

Not sure how I feel about the underbar. The only place that appears otherwise is in subsystem strings that correspond to modules that have an underbar in their name. Any reason this isn't just watch? For that matter, might it just be fine using cli or something like that? Does it need a new subsystem?

Non-blocking questions for discussion. If other people think it's fine or if this has already been discussed and I just missed it, feel free to land without engaging on this. :-D

@MoLow
Copy link
Member Author

MoLow commented Nov 6, 2022

the underbar is not very important - we can change to watch.
there are a couple of PR's related to watch mode that I dont think fit the cli subsystem:
nodejs/node#45259
nodejs/node#45271

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 for watch

@MoLow MoLow requested a review from RafaelGSS November 6, 2022 11:58
@Trott
Copy link
Member

Trott commented Nov 6, 2022

Sorry to be a pain about this, but can you squash and rewrite the commit message? I want to make sure that if we add the commit-queue label to this, the commit message says watch and not watch_mode.

@Trott
Copy link
Member

Trott commented Nov 6, 2022

We'll have to be careful to make sure that people don't use this for the fs module's watcher functionality, but I think that's a pretty unlikely error for someone to make and that reviewers would catch the error, so I'm 👍 on this.

@MoLow
Copy link
Member Author

MoLow commented Nov 6, 2022

@Trott done. can this be merged?

@GeoffreyBooth GeoffreyBooth changed the title rules: add watch_mode subsystem rules: add watch subsystem Nov 6, 2022
@Trott Trott merged commit bfadfb0 into nodejs:main Nov 7, 2022
@Trott
Copy link
Member

Trott commented Nov 7, 2022

@Trott done. can this be merged?

Whoops, forgot that we use the commit button in this repo so I guess I could have done it right in the interface. Anyway, yes, merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants