New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rules: add watch
subsystem
#103
Conversation
Codecov ReportBase: 93.93% // Head: 93.93% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=======================================
Coverage 93.93% 93.93%
=======================================
Files 19 19
Lines 462 462
=======================================
Hits 434 434
Misses 28 28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@nodejs/tsc who can approve this? |
I guess this most impacts @nodejs/releasers? |
Not sure how I feel about the underbar. The only place that appears otherwise is in subsystem strings that correspond to modules that have an underbar in their name. Any reason this isn't just Non-blocking questions for discussion. If other people think it's fine or if this has already been discussed and I just missed it, feel free to land without engaging on this. :-D |
the underbar is not very important - we can change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 for watch
Sorry to be a pain about this, but can you squash and rewrite the commit message? I want to make sure that if we add the |
We'll have to be careful to make sure that people don't use this for the fs module's watcher functionality, but I think that's a pretty unlikely error for someone to make and that reviewers would catch the error, so I'm 👍 on this. |
@Trott done. can this be merged? |
watch_mode
subsystemwatch
subsystem
Whoops, forgot that we use the commit button in this repo so I guess I could have done it right in the interface. Anyway, yes, merged, thanks! |
No description provided.