fix: re-add support for custom registries with auth #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
reviewed
Feb 25, 2024
aduh95
changed the title
arcanis
approved these changes
Mar 27, 2024
BirknerAlex
reviewed
Apr 16, 2024
| if (username || password) { | ||
| headers = { | ||
| ...headers, | ||
| authorization: `Bearer ${Buffer.from(`${username}:${password}`).toString(`base64`)}`, |
There was a problem hiding this comment.
Without testing it but I think that should be Basic instead of Bearer when using username and password. 🤔
There was a problem hiding this comment.
Good catch, thankfully it's already fixed on main: #454
There was a problem hiding this comment.
Oh sorry. Okay the fix seems not the be released yet, that might explain why it's not working. Sorry for bothering you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #275. We'd probably need separate env variable as suggested in the issue.
Blocked by #396.