Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use pipeline from node:stream/promises #441

Closed
wants to merge 1 commit into from
Closed

chore: use pipeline from node:stream/promises #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions sources/corepackUtils.ts
View file
Open in desktop
@@ -1,11 +1,11 @@
import {createHash} from 'crypto';
import {once} from 'events';
import {FileHandle} from 'fs/promises';
import fs from 'fs';
import type {Dir} from 'fs';
import Module from 'module';
import path from 'path';
import semver from 'semver';
import {pipeline} from 'stream/promises';
import {setTimeout as setTimeoutPromise} from 'timers/promises';

import * as engine from './Engine';
Expand Down Expand Up @@ -201,8 +201,8 @@ export async function installVersion(installTarget: string, locator: Locator, {s
stream.pipe(sendTo);

const algo = build[0] ?? `sha256`;
const hash = stream.pipe(createHash(algo));
await once(sendTo, `finish`);
const hash = createHash(algo);
await pipeline(sendTo, hash);

let bin: BinSpec | BinList;
const isSingleFile = outputFile !== null;
Expand Down