Skip to content

Commit

Permalink
doc: add minutes for meeting 5 March 2024 (#629)
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Dawson <midawson@redhat.com>
  • Loading branch information
mhdawson committed Apr 29, 2024
1 parent adab8d6 commit 2ae4360
Showing 1 changed file with 40 additions and 0 deletions.
40 changes: 40 additions & 0 deletions wg-meetings/2024-03-05.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Node.js Diagnostics WorkGroup Meeting 2024-03-05

## Links

* **Recording**: <https://www.youtube.com/watch?v=ePI1QS_Q3tc>
* **GitHub Issue**: <https://github.com/nodejs/diagnostics/issues/628>

## Present

* Stephen Belanger @qard
* Michael Dawson @mhdawson
* James Sumners

## Agenda

## Announcements

*Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

### nodejs/node

* diagnostics_channel: early-exit tracing channel trace methods [#51915](https://github.com/nodejs/node/pull/51915)
* diagnostic channel designed to have separate events, so you could listen to just subset of
events
* if you started listening to a channel you might get only end events, but you might get before
after ones for others.
* Challenge is that there are optimizations that can be applied if the check can be done
when first event occurs versus every time there is an event
* undici is considering re-implementing to avoid needing a closure, but current behaviour
means that you need to always do stuff versus checking for subscribers at start of event so
you get all or nothing.
* to see an event the listener needs to be in place at the start of the event

## Q&A, Other

## Upcoming Meetings

* **Node.js Project Calendar**: <https://nodejs.org/calendar>

Click `+GoogleCalendar` at the bottom right to add to your own Google calendar.

0 comments on commit 2ae4360

Please sign in to comment.