Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add abnormal termination step 1 #344

Merged
merged 2 commits into from Jan 20, 2020

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Dec 15, 2019

Confirming if the process was exited for proactive invocation of process.exit.

The option is available after nodejs/node#30516 has been landed.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Jan 6, 2020

We probably need more info in this section as well as we should explain how you can use the stack traces for debugging.

@@ -1 +1,15 @@
//TODO
# Using `--trace-exit` CLI Option
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Using `--trace-exit` CLI Option
# Using Exit Stack Traces for Debugging
//TODO
# Using `--trace-exit` CLI Option

@legendecas
Copy link
Member Author

@mhdawson PTAL again :D

Copy link
Contributor

@mmarchini mmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM with a few comments.

```

With the knowledge of where the calls of `process.exit` is, we can check around
the invocation to guess the reasons and prevent it from abnormal exits.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of using the word guess here. The whole point of using instrumentation is to empower users to make informed decisions instead of guessing why things are not working.

Suggested change
the invocation to guess the reasons and prevent it from abnormal exits.
the invocation to understand the reasons and prevent it from abnormal exits.

With the knowledge of where the calls of `process.exit` is, we can check around
the invocation to guess the reasons and prevent it from abnormal exits.

Or if we find there is no such prints on process exits, we can come to a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Or if we find there is no such prints on process exits, we can come to a
If the process doesn't output a stack trace on exit, we can come to a

the invocation to guess the reasons and prevent it from abnormal exits.

Or if we find there is no such prints on process exits, we can come to a
conclusion that the process may exited for some other obscure reasons, and we
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
conclusion that the process may exited for some other obscure reasons, and we
conclusion that the process exited for other reasons, and we


Or if we find there is no such prints on process exits, we can come to a
conclusion that the process may exited for some other obscure reasons, and we
have to deploy following steps of the Abnormal Termination guides.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, and we have to deploy following steps of the Abnormal Termination guides.

This is vague, I'd rather point the user to specific guides based on symptoms. Might be worth leaving that last part out or leaving a placeholder so we can replace it in the future when those guides are written.

Confirming if the process was exited for proactive invocation of `process.exit`.
@mmarchini mmarchini merged commit 72151d6 into nodejs:master Jan 20, 2020
@legendecas legendecas deleted the abnormal-exit branch January 21, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants