Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove 386 architecture for v12 and v14 #1347

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Oct 6, 2020

Official support stopped in v8 and is currnetly all failing in the
official-images CI.
Can be re-enabled if support is fixed

@nschonni
Copy link
Member Author

nschonni commented Oct 6, 2020

Support maybe be added back later #1344 (comment)

@nschonni nschonni requested a review from a team October 6, 2020 16:33
Official support stopped in v8 and is currnetly all failing in the
official-images CI.
Can be re-enabled if support is fixed
@nschonni nschonni changed the title fix: Revoe 386 architecture for v12 and v14 fix: Remove 386 architecture for v12 and v14 Oct 6, 2020
@nschonni
Copy link
Member Author

nschonni commented Oct 6, 2020

Going to hold of landing this to test the new PR workflow with the 12.19.0 release PR (that hasn't been submitted yet)

@nschonni nschonni merged commit 91ab1f8 into nodejs:master Oct 7, 2020
@nschonni nschonni deleted the drop-386 branch October 7, 2020 03:42
@nschonni
Copy link
Member Author

nschonni commented Oct 7, 2020

@ttshivers interesting, it doesn't look like it triggered the PR here. I wonder if it's related to the branch not being up-to-date at time of landing

@ttshivers
Copy link
Member

ttshivers commented Oct 7, 2020

I am not seeing any runs of the action: https://github.com/nodejs/docker-node/actions?query=workflow%3A%22Create+official+images+PR%22. The triggers might not be working as expected? I am not sure yet why it wasn't triggered when this was closed. Looking into it.

@nschonni
Copy link
Member Author

nschonni commented Oct 7, 2020

My first guess is maybe my suggeted filter for the merged was bad

if: github.repository_owner == 'nodejs' && github.event.pull_request.merged_by != ''

@ttshivers
Copy link
Member

My first guess is maybe my suggeted filter for the merged was bad

if: github.repository_owner == 'nodejs' && github.event.pull_request.merged_by != ''

I think if that was the issue, it would still show the actions, just they would be skipped.

@ttshivers
Copy link
Member

It appears the latest commit was not done with a merge commit, so that might be related?

@nschonni
Copy link
Member Author

nschonni commented Oct 7, 2020

Right, the commit is showing before the PR commit, so maybe if you rebase the other one I can land it to see if it works then

@ttshivers
Copy link
Member

ttshivers commented Oct 7, 2020

Right, the commit is showing before the PR commit, so maybe if you rebase the other one I can land it to see if it works then

Done. That might be it. I tested this behavior with merge commits but will investigate further about what is happening: #1337 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants