-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused openssl headers #1923
Remove unused openssl headers #1923
Conversation
Some previous discussions on this #1776 |
c880f5a
to
f71a299
Compare
f71a299
to
f863281
Compare
@yehonatanz could you rebase and fix the conflict? |
f863281
to
2c45783
Compare
Done |
2c45783
to
924180b
Compare
@LaurentGoderre rebased again now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@nodejs/docker, it might be good to add the same change to alpine
and the non-slim images.
A similar change in node itself had broken gyp dependencies when they used openssl headers. I tried to reproduce using |
@tianon Any action item for me? |
Created PR on the official-images repo (docker-library/official-images#15700). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
@yehonatanz would you be able to look into doing the same for the slim and alpine variants if needed? |
Sure, I can take a look at the alpine variants (this PR already covers the slim images) |
@LaurentGoderre Done: #1996 |
Remove unused OpenSSL headers for architectures other than current one
Description
Remove unused OpenSSL headers for platforms other than current one (linux + machine_arch).
This is a mitigation for this open NodeJS issue.
Motivation and Context
To save a few 10s of MB in all slim images:
Testing Details
I tested the following command ran successfully:
docker run node:18-buster-slim-in-this-branch node -e "console.log(require('crypto').createHash('sha256').update('bla').digest('hex'))"
Types of changes
Checklist