Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add needs-ci label #292

Merged
merged 1 commit into from Feb 27, 2021
Merged

feat: add needs-ci label #292

merged 1 commit into from Feb 27, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 11, 2021

Make the bot add a needs-ci label to all PRs that make changes to files that affects the node binary.

Refs: nodejs/node#37308

@aduh95 aduh95 requested a review from a team as a code owner February 11, 2021 18:10
@phillipj
Copy link
Member

Ref your nodejs/node#37308 (comment) about TSC consensus, I'll hold on reviewing this for now. Shout when there's news from TSC 😄

@aduh95
Copy link
Contributor Author

aduh95 commented Feb 26, 2021

nodejs/node#37308 has landed :)

Copy link
Contributor

@mmarchini mmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really move this to an Action 😅

@phillipj phillipj merged commit 737094c into nodejs:master Feb 27, 2021
@phillipj
Copy link
Member

We should really move this to an Action 😅

Without a doubt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants