Disable labelling of PRs as it is replaced by GitHub Action #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step of removing labelling of PRs as they are opened. Only the part actively listening for newly opened PRs gets removed now, with the main goal of *stopping* @nodejs-github-bot from applying labels and thereby leaving room for nodejs/node-pr-labeler GitHub Action to apply those labels intead. Still a lot of code that can be removed, like the actually logic of resolving labels which has been extracted into the said GitHub Action, but postponing that to a followup PR, when seeing the Action behaving as expected -- if not, these changes might be reverted as a fallback. Refs https://github.com/nodejs/node-pr-labeler
mmarchini
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step of removing labelling of PRs as they are opened.
Only the part actively listening for newly opened PRs gets removed now, with the main goal of stopping @nodejs-github-bot from applying labels and thereby leaving room for nodejs/node-pr-labeler GitHub Action to apply those labels instead.
Still a lot of code that can be removed, like the actually logic of resolving labels which has been extracted into the said GitHub Action, but postponing that to a followup PR, when seeing the Action behaving as expected -- if not, these changes might be reverted as a fallback.
Refs nodejs/node#38301