Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add stale issue action #4072

Closed
wants to merge 1 commit into from

Conversation

bmuenzenmeyer
Copy link
Contributor

closes nodejs/admin#757

Draws off of nodejs/node#42085 to implement very generous stale issue management to the help repo.

As an initial draft I am targeting a 3 year staleness mark - which would mark these issues

Since this is the first time a workflow action is in this repo - I am unsure if anything else needs to be configured on the admin side.

Copy link
Contributor Author

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review

Comment on lines +11 to +17
There has been no activity on this issue
and it is being closed. If you feel closing this issue is not the
right thing to do, please leave a comment.
WARN_MESSAGE: >
There has been no activity on this issue for
3 years and it may no longer be relevant.
It will be closed 1 month after the last non-automated comment.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about adding info about where better places to post help might be, but per conversation within nodejs/admin#757 I think we can proactively put that on the front-end of issue creation (template, README, https://github.com/marketplace/actions/welcome-new-users)

these messages over in nodejs/node#42085 also included a link to docs on how feature requests are managed. If we need to document this policy somewhere, I am happy to add that too (I just don't know where, or if it's even needed).

steps:
- uses: actions/stale@v4
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these tokens available at the org level?

# 3 years. this number is chosen to target around 25 initial issues, with then a natural flow as time progresses
days-before-stale: 1095
days-before-close: 30
stale-issue-label: stale
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

existing label stalled can probably be removed if this PR is merged

stalled issues that did not receive response for a month

@bmuenzenmeyer
Copy link
Contributor Author

cc @nodejs/actions

Copy link
Member

@gireeshpunathil gireeshpunathil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM - not skilled to review this code, but agree in principle

@gireeshpunathil
Copy link
Member

/cc @Trott

gireeshpunathil pushed a commit that referenced this pull request Jan 22, 2023
PR-URL: #4072
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@gireeshpunathil
Copy link
Member

landed in 5b6b462

@bmuenzenmeyer bmuenzenmeyer deleted the 757-stale-workflow branch February 25, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta: Add stale issue management to nodejs/help repo
4 participants