Skip to content

Commit

Permalink
meta: add policy to land PRs without approval
Browse files Browse the repository at this point in the history
As discussed in the 2020-02-12 Diagnostics WG Meeting and suggested in
#242 (comment),
change the landing policy so that Collaborators can land pull requests
if it was open for three days and there were no reviews on it.

Ref: nodejs/diagnostics#355

PR-URL: #336
Refs: nodejs/diagnostics#355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
mmarchini committed Feb 22, 2020
1 parent bff9f5e commit bd3a1c7
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,6 @@ with the following differences:
- There's no minimum wait time for landing a pull request. Pull requests can
land as soon as they get approved by at least one Collaborator.
- Approval must be from Collaborators who are not authors of the change.
- If the pull request was open for three days (72 hours) without reviews, and
it was opened by a llnode Collaborator, the pull request can land without
approvals.

0 comments on commit bd3a1c7

Please sign in to comment.