Add Function::Call wrapper

nodejs · Jan 9, 2016 · 4c15747 · 4c15747
1 parent 222d0a8
commit 4c15747
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -163,6 +163,7 @@ The `Nan::MaybeLocal` and `Nan::Maybe` types are monads that encapsulate `v8::Lo
   - <a href="doc/maybe_types.md#api_nan_nothing"><b><code>Nan::Nothing</code></b></a>
   - <a href="doc/maybe_types.md#api_nan_just"><b><code>Nan::Just</code></b></a>
 * **Maybe Helpers**
+  - <a href="doc/maybe_types.md#api_nan_call"><b><code>Nan::Call()</code></b></a>
   - <a href="doc/maybe_types.md#api_nan_to_detail_string"><b><code>Nan::ToDetailString()</code></b></a>
   - <a href="doc/maybe_types.md#api_nan_to_array_index"><b><code>Nan::ToArrayIndex()</code></b></a>
   - <a href="doc/maybe_types.md#api_nan_equals"><b><code>Nan::Equals()</code></b></a>
@@ -290,7 +291,7 @@ The hooks to access V8 internals—including GC and statistics—are different a
  - <a href="doc/v8_misc.md#api_nan_get_current_context"><b><code>Nan::GetCurrentContext()</code></b></a>
  - <a href="doc/v8_misc.md#api_nan_set_isolate_data"><b><code>Nan::SetIsolateData()</code></b></a>
  - <a href="doc/v8_misc.md#api_nan_get_isolate_data"><b><code>Nan::GetIsolateData()</code></b></a>
- - <a href="doc/v8_misc.md#api_nan_typedarray_contents"><b><code>Nan::TypedArrayContents</code></b></a>
+ - <a href="doc/v8_misc.md#api_nan_typedarray_contents"><b><code>Nan::TypedArrayContents<T></code></b></a>
 
 
 ### Miscellaneous Node Helpers

diff --git a/doc/maybe_types.md b/doc/maybe_types.md
@@ -8,6 +8,7 @@ The `Nan::MaybeLocal` and `Nan::Maybe` types are monads that encapsulate `v8::Lo
   - <a href="#api_nan_nothing"><b><code>Nan::Nothing</code></b></a>
   - <a href="#api_nan_just"><b><code>Nan::Just</code></b></a>
 * **Maybe Helpers**
+  - <a href="#api_nan_call"><b><code>Nan::Call()</code></b></a>
   - <a href="#api_nan_to_detail_string"><b><code>Nan::ToDetailString()</code></b></a>
   - <a href="#api_nan_to_array_index"><b><code>Nan::ToArrayIndex()</code></b></a>
   - <a href="#api_nan_equals"><b><code>Nan::Equals()</code></b></a>
@@ -113,6 +114,17 @@ Construct a `Nan::Maybe` type representing _just_ a value.
 template<typename T> Nan::Maybe<T> Nan::Just(const T &t);
 ```
 
+<a name="api_nan_call"></a>
+### Nan::Call()
+
+A helper method for calling [`v8::Function#Call()`](https://v8docs.nodesource.com/io.js-3.0/d5/d54/classv8_1_1_function.html#a468a89f737af0612db10132799c827c0) in a way compatible across supported versions of V8.
+
+Signature:
+
+```c++
+Nan::MaybeLocal<v8::Value> Nan::Call(v8::Local<v8::Function> fun, v8::Local<v8::Object> recv, int argc, v8::Local<v8::Value> argv[]);
+```
+
 
 <a name="api_nan_to_detail_string"></a>
 ### Nan::ToDetailString()

diff --git a/nan_maybe_43_inl.h b/nan_maybe_43_inl.h
@@ -220,4 +220,12 @@ NAN_INLINE MaybeLocal<v8::Object> CloneElementAt(
   return array->CloneElementAt(GetCurrentContext(), index);
 }
 
+NAN_INLINE MaybeLocal<v8::Value> Call(
+    v8::Local<v8::Function> fun
+  , v8::Local<v8::Object> recv
+  , int argc
+  , v8::Local<v8::Value> argv[]) {
+  return fun->Call(GetCurrentContext(), recv, argc, argv);
+}
+
 #endif  // NAN_MAYBE_43_INL_H_
diff --git a/nan_maybe_pre_43_inl.h b/nan_maybe_pre_43_inl.h
@@ -292,4 +292,12 @@ NAN_INLINE MaybeLocal<v8::Object> CloneElementAt(
   return MaybeLocal<v8::Object>(array->CloneElementAt(index));
 }
 
+NAN_INLINE MaybeLocal<v8::Value> Call(
+    v8::Local<v8::Function> fun
+  , v8::Local<v8::Object> recv
+  , int argc
+  , v8::Local<v8::Value> argv[]) {
+  return MaybeLocal<v8::Value>(fun->Call(recv, argc, argv));
+}
+
 #endif  // NAN_MAYBE_PRE_43_INL_H_