fix(v8): support non-relative paths in V8 DEPS #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V8 versions < 8.6 do not specify a relative path in the DEPS file. Fixes: nodejs/node-v8#166 Refs: v8/v8@56bf834 Refs: nodejs@57b7df8
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
=======================================
Coverage 82.58% 82.58%
=======================================
Files 34 34
Lines 1665 1665
=======================================
Hits 1375 1375
Misses 290 290 Continue to review full report at Codecov.
|
codebytere
approved these changes
Aug 11, 2020
mmarchini
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 versions < 8.6 do not specify a relative path in the DEPS file.
Fixes: nodejs/node-v8#166
Refs: v8/v8@56bf834
Refs: 57b7df8
I tested the code with
--branch=8.5-lkgrand--branch=lkgr(8.6/master)