Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automate creation of the first LTS release #514

Merged
merged 4 commits into from Nov 1, 2020

Conversation

richardlau
Copy link
Member

Add an option to git node release that marks the release being
created as the transition from Current to LTS.

cc @nodejs/releasers

Add an option to `git node release` that marks the release being
created as the transition from Current to LTS.
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #514 into master will increase coverage by 0.19%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   82.29%   82.49%   +0.19%     
==========================================
  Files          34       35       +1     
  Lines        1717     1742      +25     
==========================================
+ Hits         1413     1437      +24     
- Misses        304      305       +1     
Impacted Files Coverage Δ
lib/release/utils.js 96.00% <96.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c0cf83...60208b0. Read the comment docs.

@richardlau richardlau mentioned this pull request Oct 22, 2020
4 tasks
@richardlau
Copy link
Member Author

See https://gist.github.com/richardlau/17d87552525d4e05da1298163fdf7cb7 for a sample session (creating v14.15.0-proposal for nodejs/node#35746).

@codebytere codebytere self-requested a review October 22, 2020 01:02
Comment on lines 273 to 276
return await cli.prompt(
'Enter the LTS code name for this release line:',
{ questionType: 'input', noSeparator: true, defaultAnswer: '' }
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlau
Copy link
Member Author

14.15.0 (created using this PR in its current state) has now gone out.

@targos targos merged commit 53e68b4 into nodejs:master Nov 1, 2020
@richardlau richardlau deleted the releaselts branch November 1, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants