Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accommodate case changes in README header #531

Merged
merged 1 commit into from Feb 8, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 8, 2021

Because of changes to the README, node-core-utils git node land is now
broken. This fixes it. Please fast-track?

Because of changes to the README, node-core-utils `git node land` is now
broken. This fixes it. Please fast-track?
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #531 (d4bf81f) into master (a10942b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #531   +/-   ##
=======================================
  Coverage   82.51%   82.51%           
=======================================
  Files          35       35           
  Lines        1744     1744           
=======================================
  Hits         1439     1439           
  Misses        305      305           
Impacted Files Coverage Δ
lib/collaborators.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10942b...389c3a1. Read the comment docs.

@Trott
Copy link
Member Author

Trott commented Feb 8, 2021

I used the patch here to land nodejs/node#37279, so there's confirmation that it works "in the wild".

@Trott
Copy link
Member Author

Trott commented Feb 8, 2021

Still waiting on two GitHub Actions checks to pass but they've been queued a loooong time it seems. Should we just land it?

@priyank-p
Copy link
Contributor

The MacOS platform tend to have longer queue times, but, I think this is good to merge since test passed in linux. I'll go ahead and merge this.

@priyank-p priyank-p merged commit e8ef932 into nodejs:master Feb 8, 2021
@Trott Trott deleted the fix-collaborators.js branch February 8, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants