Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update detection of changelog links #573

Merged
merged 1 commit into from Oct 25, 2021

Conversation

richardlau
Copy link
Member

The Node.js CHANGELOG.md file was changed so that _ characters in
links are now escaped.

Refs: nodejs/node#40322


Note that we'll need to update again after nodejs/node#40475 but for now this needs to work against the current v16.x-staging branch.

The Node.js `CHANGELOG.md` file was changed so that `_` characters in
links are now escaped.

Refs: nodejs/node#40322
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #573 (3bd7dfd) into main (3091f99) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files          35       35           
  Lines        1750     1750           
=======================================
  Hits         1445     1445           
  Misses        305      305           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3091f99...3bd7dfd. Read the comment docs.

@Trott
Copy link
Member

Trott commented Oct 20, 2021

I put HTML comments in the README to remind people (including myself) of tooling that needs to be updated if the format of certain parts change. Maybe we can/should do that for CHANGELOG too?

https://github.com/nodejs/node/blame/master/README.md#L159-L160
https://github.com/nodejs/node/blame/master/README.md#L262-L264

@richardlau
Copy link
Member Author

I put HTML comments in the README to remind people (including myself) of tooling that needs to be updated if the format of certain parts change. Maybe we can/should do that for CHANGELOG too?

https://github.com/nodejs/node/blame/master/README.md#L159-L160 https://github.com/nodejs/node/blame/master/README.md#L262-L264

Sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants