fix: use getUrlFromOP() for fixes links
#614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing `fixes` links, use the same code that is used for parsing the `refs` and `PR-URL` links. This avoids the manual URL construction that was inserting bad links into the metadata for the npm update pull requests.
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
==========================================
- Coverage 84.10% 84.09% -0.01%
==========================================
Files 37 37
Lines 4051 4049 -2
==========================================
- Hits 3407 3405 -2
Misses 644 644
Continue to review full report at Codecov.
|
richardlau
commented
Mar 19, 2022
ruyadorno
approved these changes
Mar 24, 2022
|
Anyone have any ideas about the coverage drop/failure? Are we able to land with this check failing? FWIW TIL that $ npx node-core-utils 42550
npx: installed 493 in 17.679s
✔ Done loading data for nodejs/node/pull/42550
----------------------------------- PR info ------------------------------------
Title deps: upgrade npm to 8.6.0 (#42550)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch npm-robot:npm-8.6.0 -> nodejs:master
Labels npm, fast-track, needs-ci, dont-land-on-v12.x, dont-land-on-v14.x
Commits 1
- deps: upgrade npm to 8.6.0
Committers 1
- npm team <ops+robot@npmjs.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42550
Fixes: https://github.com/remove
Fixes: https://github.com/100%
Fixes: https://github.com/make
Fixes: https://github.com/move
Fixes: https://github.com/really
Fixes: https://github.com/consolidate
Fixes: https://github.com/consolidate
Fixes: https://github.com/consolidate
Fixes: https://github.com/consolidate
Fixes: https://github.com/bump
Fixes: https://github.com/return
Fixes: https://github.com/consolidate
Fixes: https://github.com/work
Fixes: https://github.com/only
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
--------------------------------------------------------------------------------
ℹ This PR was created on Thu, 31 Mar 2022 22:43:19 GMT
✔ Approvals: 4
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-928307710
✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42550#pullrequestreview-928452353
✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474922
✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474971
ℹ This PR is being fast-tracked
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2022-04-01T08:44:02Z: https://ci.nodejs.org/job/node-test-pull-request/43255/
✔ Build data downloaded
✔ Last Jenkins CI successfulwhile with this PR: $ node bin/get-metadata.js 42550
✔ Done loading data for nodejs/node/pull/42550
----------------------------------- PR info ------------------------------------
Title deps: upgrade npm to 8.6.0 (#42550)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch npm-robot:npm-8.6.0 -> nodejs:master
Labels npm, fast-track, needs-ci, dont-land-on-v12.x, dont-land-on-v14.x
Commits 1
- deps: upgrade npm to 8.6.0
Committers 1
- npm team <ops+robot@npmjs.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42550
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
--------------------------------------------------------------------------------
ℹ This PR was created on Thu, 31 Mar 2022 22:43:19 GMT
✔ Approvals: 4
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-928307710
✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42550#pullrequestreview-928452353
✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474922
✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474971
ℹ This PR is being fast-tracked
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2022-04-01T08:44:02Z: https://ci.nodejs.org/job/node-test-pull-request/43255/
✔ Build data downloaded
✔ Last Jenkins CI successful |
Yes. I'll land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing
fixeslinks, use the same code that is used for parsingthe
refsandPR-URLlinks. This avoids the manual URL constructionthat was inserting bad links into the metadata for the npm update pull
requests.
Refs: nodejs/node#42382 (comment)
This is an alternative to #612 which also fixes the case in #612 (comment).