Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git-node): update README parser to account the recent TSC changes #688

Merged
merged 1 commit into from Sep 24, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 22, 2023

Refs: nodejs/node#47126
Refs: nodejs/TSC#1350

BREAKING CHANGE: Old README format is no longer supported

BREAKING CHANGE: Old README format is no longer supported
@richardlau
Copy link
Member

Refs: nodejs/node#46985

BREAKING CHANGE: Old README format is no longer supported

Is that going to break using node-core-utils to land PR's in LTS lines? cc @nodejs/releasers

@aduh95
Copy link
Contributor Author

aduh95 commented Mar 22, 2023

Is that going to break using node-core-utils to land PR's in LTS lines?

I was about to comment regarding that. We need to either backport the README recent updates first, or backporters would need to use the main version of the README (which seems to be the default anyway?).

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (92d621e) 83.45% compared to head (4fdf802) 83.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   83.45%   83.35%   -0.10%     
==========================================
  Files          37       37              
  Lines        4158     4164       +6     
==========================================
+ Hits         3470     3471       +1     
- Misses        688      693       +5     
Impacted Files Coverage Δ
lib/collaborators.js 98.57% <100.00%> (-1.43%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Trott
Copy link
Member

Trott commented Mar 27, 2023

Not sure if it will help here, but here's what I did to make find-inactive-tsc.mjs backwards compatible: https://github.com/nodejs/node/blob/a4808b6c3b111608e0b9945c7f62534b285b0c96/tools/find-inactive-tsc.mjs#L56-L86

@aduh95
Copy link
Contributor Author

aduh95 commented Sep 24, 2023

I think we should land this, the README change have landed on all supported release lines. wdyt @nodejs/node-core-utils?

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 merged commit 7382454 into nodejs:main Sep 24, 2023
@aduh95 aduh95 deleted the readme branch September 24, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants