build: shrink bloated addon binaries on windows

[codebytere]

Checklist

• npm install && npm test passes
• commit message follows commit guidelines

Description of change

Closes nodejs/node#29501.
Refs #1118.

Moves build-time optimizations to node-gyp to shrink the binary size accidentally bloated by a change to common.gypi in core. Also furthers the goal of decoupling addons from being affected by common.gypi changes.

Feel free to tell me if this isn't quite what the issue had in mind and i'll adapt accordingly.

cc @richardlau @deepak1556

[rvagg]

Are there any backward compatibility concerns with this, or is it just going to impact size? It'd be good one to repeat the problems we had with duplicate symbol checking #1891

tagged @joaocgreis too

[codebytere]

@rvagg to my knowledge this just affects size!

[rvagg]

sgtm, would prefer one of our windows reviewers to sign off tho

[bzoz]

LGTM!

Used this node-gyp to run Node vcbuild test-addons, everything was ok.

[rvagg]

cool, landed @ e18a61a

[cclauss]

Nice work. Size matters. Do we have a few anecdotes about how much smaller the new binaries are?

[rvagg]

btw is there any reason to not backport this to 5.x?

[codebytere]

@rvagg oops, this blew me by - no i don't think so, we should be fine to land this on 5.x

[codebytere]

@rvagg what's the typical backport process for this? I can open a PR against the5.x branch if that'd be helpful?

[rvagg]

Ah, not really a proper process or timeline for this. I normally just cherry-pick things not server-major, 5.x is super close to master anyway. I’ll try and do a batch this week and see what it looks like for a release. I guess were due for some action around here including a 7.x.