Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: give more attention to Catalina issues doc #2134

Closed
wants to merge 1 commit into from

Conversation

mmarchini
Copy link
Contributor

It's easy to miss the Catalina issues doc when reading the readme. Since
it can be a common issue among developers, it makes sense to give more
attention to it in the readme.

Checklist

It's easy to miss the Catalina issues doc when reading the readme. Since
it can be a common issue among developers, it makes sense to give more
attention to it in the readme.
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if too many people actually come to the README for help, Google -> Issues seems to be the most common path these days. But this is fine by me.

@mmarchini
Copy link
Contributor Author

Agreed, but even finding via Google is not so ergonomic unfortunately. Depending on the query used, the first few results Google gives you are from other unrelated repositories, and not from node-gyp (that's the result I got when searching the error on Google at least).

I also suggested adding a link to the guide on the website (nodejs/nodejs.org#3180), so at least there's another way to find it (and maybe it improves SEO for the guide? IDK how SEO works).

rvagg pushed a commit that referenced this pull request May 26, 2020
It's easy to miss the Catalina issues doc when reading the readme. Since
it can be a common issue among developers, it makes sense to give more
attention to it in the readme.

PR-URL: #2134
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Christian Clauss <cclauss@me.com>
@rvagg
Copy link
Member

rvagg commented May 26, 2020

9aed628

@rvagg rvagg closed this May 26, 2020
@rvagg rvagg mentioned this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants