This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
buffer: introduce Buffer#toArrayBuffer() API #6337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #undef CHECK_NOT_OOB | ||
| #undef ARGS_THIS | ||
| #undef SLICE_START_END | ||
|
|
There was a problem hiding this comment.
#undef'ing these isn't necessary, because the macros don't potentially conflict with anything else in the file, nor will they conflict with anyone else in the build system unless someone #include <node_buffer.cc> which would almost certainly cause symbol conflicts in their build since this file doesn't have include guards :)
There was a problem hiding this comment.
oh duh. I'm thinking headers here. working on async-wrap.h and async-wrap-inl.h for so long has warped me a little.
Because it's possible for the data within a Buffer instance to be
altered after instantiation, or in case a user attempts to do something
like the following:
Buffer.prototype.fill.call({}, 10, 0, 10);
It doesn't result in a segfault.
|
I'm basically +1 on this, I think there are more ways we can improve Buffer/ArrayBuffer interactions |
var buf = new Buffer(1024*1024);
setInterval(function(){
var b = new Uint8Array(buf.toArrayBuffer());
},10);eats memory like crazy |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes a few small fixes.