Skip to content

Commit

Permalink
build: simplify v8's vendored zlib build
Browse files Browse the repository at this point in the history
It only uses adler32() and only in one place that's arguably not very
performance critical so simplify the build by building just adler32.c
and nothing else.
  • Loading branch information
bnoordhuis authored and nodejs-ci committed Jan 8, 2020
1 parent e7d2803 commit c8583da
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 102 deletions.
13 changes: 12 additions & 1 deletion tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@
'generate_bytecode_builtins_list',
'run_torque',
'v8_maybe_icu',
'zlib.gyp:zlib'
'v8_zlib',
],
'includes': ['inspector.gypi'],
'direct_dependent_settings': {
Expand Down Expand Up @@ -1599,5 +1599,16 @@
'sources': ['<(SHARED_INTERMEDIATE_DIR)/debug-support.cc', ],
},
}, # postmortem-metadata

{
'target_name': 'v8_zlib',
'type': 'static_library',
'direct_dependent_settings': {
'include_dirs': [ '<(V8_ROOT)/third_party/zlib' ],
},
'defines': [ 'ZLIB_IMPLEMENTATION' ],
'include_dirs': [ '<(V8_ROOT)/third_party/zlib' ],
'sources': [ '<(V8_ROOT)/third_party/zlib/adler32.c' ],
}, # v8_zlib
],
}
101 changes: 0 additions & 101 deletions tools/v8_gypfiles/zlib.gyp

This file was deleted.

0 comments on commit c8583da

Please sign in to comment.