Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8: remove deprecated method #149

Closed
wants to merge 29 commits into from
Closed

v8: remove deprecated method #149

wants to merge 29 commits into from

Commits on Mar 8, 2020

  1. doc: update README for node-v8 repository

    @nodejs-ci
    nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    436afed View commit details
    Browse the repository at this point in the history

  2. deps: update V8 to 8.2.0

    @nodejs-ci
    nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    51acddb View commit details
    Browse the repository at this point in the history

  3. build: reset embedder string to "-node.0"

    @nodejs-ci
    nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    50a6724 View commit details
    Browse the repository at this point in the history

  4. tools: update V8 gypfiles for 8.1 

    Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Richard Lau <riclau@uk.ibm.com>
Co-authored-by: Ujjwal Sharma <ryzokuken@igalia.com>
    @mmarchini @bnoordhuis
    @targos @richardlau @ryzokuken @nodejs-ci
    5 people authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    4cf01f0 View commit details
    Browse the repository at this point in the history

  5. deps: update V8 dtrace & postmortem metadata

    @cjihrig @nodejs-ci
    cjihrig authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    56cb21e View commit details
    Browse the repository at this point in the history

  6. deps: V8: un-cherry-pick bd019bd 

    Original commit message:

    [testrunner] delete ancient junit compatible format support

    Testrunner has ancient support for JUnit compatible XML output.

    This CL removes this old feature.

    R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
    CC=​machenbach@chromium.org

    Bug: v8:8728
    Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1430065
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Tamer Tas <tmrts@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59045}

Refs: v8/v8@bd019bd
    @refack @nodejs-ci
    refack authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    c193ed8 View commit details
    Browse the repository at this point in the history

  7. deps: patch V8 to run on older XCode versions 

    Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
property, which is a fairly new C++ feature, since that requires a newer
XCode version than the minimum requirement in BUILDING.md and thus
breaks CI.
    @ryzokuken @nodejs-ci
    ryzokuken authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    415c8b3 View commit details
    Browse the repository at this point in the history

  8. deps: V8: patch register-arm64.h 

    Fixes a compilation issue on some platforms
    @refack @nodejs-ci
    refack authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    4f4195a View commit details
    Browse the repository at this point in the history

  9. deps: V8: forward declaration of Rtl*FunctionTable 

    This should be semver-patch since actual invocation is version
conditional.
    @refack @nodejs-ci
    refack authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    43c2180 View commit details
    Browse the repository at this point in the history

  10. deps: make v8.h compatible with VS2015 

    There is a bug in the most recent version of VS2015 that affects v8.h
and therefore prevents compilation of addons.

Refs: https://stackoverflow.com/q/38378693
    @joaocgreis @nodejs-ci
    joaocgreis authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    95925f9 View commit details
    Browse the repository at this point in the history

  11. Revert "assert: fix line number calculation after V8 upgrade" 

    This reverts commit 5981fb7.
    @targos @nodejs-ci
    targos authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    d2477d2 View commit details
    Browse the repository at this point in the history

  12. deps: bump minimum icu version to 65 

    Bump minimum version of ICU needed to build node to 65.

Refs: v8/v8@74bf96e
    @targos @nodejs-ci
    targos authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    4a05ead View commit details
    Browse the repository at this point in the history

  13. deps: V8: cherry-pick 1e36e21acc40 

    Original commit message:

    Remove unnecessary export, which happens to break MSVC DLL builds.

    Change-Id: I47c9211274cefd26bde6bd93aa7503e022df4357
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2042874
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Commit-Queue: Bill Ticehurst <billti@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#66179}

Refs: v8/v8@1e36e21
    @mmarchini @nodejs-ci
    mmarchini authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    45f9e6c View commit details
    Browse the repository at this point in the history

  14. deps: include right headers in torque output 

    Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
    @gengjiawen @bnoordhuis @nodejs-ci
    2 people authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    665c55d View commit details
    Browse the repository at this point in the history

  15. src: stop overriding deprecated V8 methods 

    These methods will be removed in V8 8.1, hence we need to stop
overriding them.
    @backes @nodejs-ci
    backes authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    2578bf3 View commit details
    Browse the repository at this point in the history

  16. src: remove use of deprecated Symbol::Name() 

    This commit replaces Symbol::Name() with
Symbol::Description().

Fixes: nodejs/node#30916
    @cjihrig @nodejs-ci
    cjihrig authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    f6d0a92 View commit details
    Browse the repository at this point in the history

  17. src: avoid calling deprecated method 

    The {SetExpectInlineWasm} method is deprecated and non-functional since
V8 v8.1.
Thus node should stop calling it, so that it can be fully removed in a
future v8 version.
    @backes @nodejs-ci
    backes authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    bd569a6 View commit details
    Browse the repository at this point in the history

  18. src: remove deprecated wasm type check 

    This removes uses of the "IsWebAssemblyCompiledModule" method, which is
deprecated in V8 v8.1 and will be removed in v8.2.
We could replace it by "IsWasmModuleObject", but since it's unused in
node anyway, I just remove the definition.
    @backes @nodejs-ci
    backes authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    40c39c6 View commit details
    Browse the repository at this point in the history

  19. test: remove checks for deserializing wasm 

    V8 is removing support for serializing wasm modules via the value
serializer. Once this is complete (https://crrev.com/c/2013110), we can
re-add this test.
    @mmarchini @nodejs-ci
    mmarchini authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    5b82c61 View commit details
    Browse the repository at this point in the history

  20. test: remove test

    @backes @nodejs-ci
    backes authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    446d460 View commit details
    Browse the repository at this point in the history

  21. test: mark inspector tests as flaky 

    Ref: https://github.com/nodejs/node-v8/issues/120
Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
    @mmarchini @nodejs-ci
    mmarchini authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    d9c4fad View commit details
    Browse the repository at this point in the history

  22. src: migrate measureMemory to new v8 api

    @gengjiawen @nodejs-ci
    gengjiawen authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    591b4d2 View commit details
    Browse the repository at this point in the history

  23. tools: update V8 gypfiles 

    until 72fc962b4db88af63a50e8f0b0a33313eb2e08ff
    @targos @nodejs-ci
    targos authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    81c1703 View commit details
    Browse the repository at this point in the history

  24. tools: update v8 gypfiles 

    until fe6bd3019d47c8522e2cad2bb52fd82dce906485
    @targos @nodejs-ci
    targos authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    428c444 View commit details
    Browse the repository at this point in the history

  25. tools: update v8 gypfiles 

    until 4c7c6f732cb607676bec1c9acb570e91ddfc507d
    @targos @nodejs-ci
    targos authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    4efd8f0 View commit details
    Browse the repository at this point in the history

  26. Rename FinalizationGroup to FinalizationRegistry

    @syg @nodejs-ci
    syg authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    91b70ff View commit details
    Browse the repository at this point in the history

  27. deps: revert postmortem metadata floating patch

    @mmarchini @nodejs-ci
    mmarchini authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    13fb00a View commit details
    Browse the repository at this point in the history

  28. build: update V8 gypfiles

    @mmarchini @nodejs-ci
    mmarchini authored and nodejs-ci committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    1e24bf6 View commit details
    Browse the repository at this point in the history

  29. v8: remove deprecated method

    @gengjiawen
    gengjiawen committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    4f5d403 View commit details
    Browse the repository at this point in the history