Skip to content

http: cleanup cork logic #56487

http: cleanup cork logic

http: cleanup cork logic #56487

Triggered via pull request May 12, 2024 10:17
Status Failure
Total duration 2h 4m 5s
Artifacts

test-linux.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors
test-linux: test/parallel/test-http-1.0.js#L158
--- stderr --- node:assert:126 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: + actual - expected ... Lines skipped 'HTTP/1.1 200 OK\r\n' + 'Content-Type: text/plain\r\n' + ... '7\r\n' + 'Hello, \r\n' + + '0\r\n' + + '\r\n' + + '6\r\n' + + 'world!\r\n' - '6\r\n' + - 'world!\r\n' + - '0\r\n' + - '\r\n' at response_validator (/home/runner/work/node/node/test/parallel/test-http-1.0.js:158:12) at Socket.<anonymous> (/home/runner/work/node/node/test/parallel/test-http-1.0.js:54:7) at Socket.<anonymous> (/home/runner/work/node/node/test/common/index.js:470:15) at Socket.emit (node:events:532:35) at endReadableNT (node:internal/streams/readable:1696:12) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) { generatedMessage: true, code: 'ERR_ASSERTION', actual: 'HTTP/1.1 200 OK\r\n' + 'Content-Type: text/plain\r\n' + 'Connection: close\r\n' + 'Transfer-Encoding: chunked\r\n' + '\r\n' + '7\r\n' + 'Hello, \r\n' + '0\r\n' + '\r\n' + '6\r\n' + 'world!\r\n', expected: 'HTTP/1.1 200 OK\r\n' + 'Content-Type: text/plain\r\n' + 'Connection: close\r\n' + 'Transfer-Encoding: chunked\r\n' + '\r\n' + '7\r\n' + 'Hello, \r\n' + '6\r\n' + 'world!\r\n' + '0\r\n' + '\r\n', operator: 'strictEqual' } Node.js v23.0.0-pre Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http-1.0.js
test-linux: test/parallel/test-http-abort-stream-end.js#L1
--- stderr --- node:events:498 throw er; // Unhandled 'error' event ^ Error: Parse Error: Expected HTTP/ at Socket.socketOnData (node:_http_client:542:22) at Socket.emit (node:events:520:28) at addChunk (node:internal/streams/readable:559:12) at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) at Readable.push (node:internal/streams/readable:390:5) at TCP.onStreamRead (node:internal/stream_base_commons:191:23) Emitted 'error' event on ClientRequest instance at: at Socket.socketOnData (node:_http_client:551:9) at Socket.emit (node:events:520:28) [... lines matching original stack trace ...] at TCP.onStreamRead (node:internal/stream_base_commons:191:23) { bytesParsed: 169, code: 'HPE_INVALID_CONSTANT', reason: 'Expected HTTP/', rawPacket: Buffer(4022) [Uint8Array] [ 72, 84, 84, 80, 47, 49, 46, 49, 32, 50, 48, 48, 32, 79, 75, 13, 10, 67, 111, 110, 116, 101, 110, 116, 45, 84, 121, 112, 101, 58, 32, 116, 101, 120, 116, 47, 112, 108, 97, 105, 110, 13, 10, 68, 97, 116, 101, 58, 32, 83, 117, 110, 44, 32, 49, 50, 32, 77, 97, 121, 32, 50, 48, 50, 52, 32, 49, 48, 58, 53, 55, 58, 48, 49, 32, 71, 77, 84, 13, 10, 67, 111, 110, 110, 101, 99, 116, 105, 111, 110, 58, 32, 107, 101, 101, 112, 45, 97, 108, 105, ... 3922 more items ] } Node.js v23.0.0-pre Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http-abort-stream-end.js
test-linux: test/parallel/test-http-byteswritten.js#L1
--- stderr --- node:events:498 throw er; // Unhandled 'error' event ^ Error: Parse Error: Expected HTTP/ at Socket.socketOnData (node:_http_client:542:22) at Socket.emit (node:events:520:28) at addChunk (node:internal/streams/readable:559:12) at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) at Readable.push (node:internal/streams/readable:390:5) at TCP.onStreamRead (node:internal/stream_base_commons:191:23) Emitted 'error' event on ClientRequest instance at: at Socket.socketOnData (node:_http_client:551:9) at Socket.emit (node:events:520:28) [... lines matching original stack trace ...] at TCP.onStreamRead (node:internal/stream_base_commons:191:23) { bytesParsed: 1193, code: 'HPE_INVALID_CONSTANT', reason: 'Expected HTTP/', rawPacket: Buffer(53425) [Uint8Array] [ 72, 84, 84, 80, 47, 49, 46, 49, 32, 50, 48, 48, 32, 79, 75, 13, 10, 67, 111, 110, 116, 101, 110, 116, 45, 84, 121, 112, 101, 58, 32, 116, 101, 120, 116, 47, 112, 108, 97, 105, 110, 13, 10, 68, 97, 116, 101, 58, 32, 83, 117, 110, 44, 32, 49, 50, 32, 77, 97, 121, 32, 50, 48, 50, 52, 32, 49, 48, 58, 53, 55, 58, 48, 51, 32, 71, 77, 84, 13, 10, 67, 111, 110, 110, 101, 99, 116, 105, 111, 110, 58, 32, 107, 101, 101, 112, 45, 97, 108, 105, ... 53325 more items ] } Node.js v23.0.0-pre Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http-byteswritten.js
test-linux: test/parallel/test-http-client-upload.js#L39
--- stderr --- node:assert:126 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: + actual - expected + '1\n' - '1\n2\n3\n' ^ at IncomingMessage.<anonymous> (/home/runner/work/node/node/test/parallel/test-http-client-upload.js:39:12) at IncomingMessage.<anonymous> (/home/runner/work/node/node/test/common/index.js:470:15) at IncomingMessage.emit (node:events:520:28) at endReadableNT (node:internal/streams/readable:1696:12) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) { generatedMessage: true, code: 'ERR_ASSERTION', actual: '1\n', expected: '1\n2\n3\n', operator: 'strictEqual' } Node.js v23.0.0-pre --- stdout --- server got: "1\n" Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http-client-upload.js
test-linux: test/parallel/test-http-content-length.js#L1
--- stderr --- node:events:498 throw er; // Unhandled 'error' event ^ Error: Parse Error: Expected HTTP/ at Socket.socketOnData (node:_http_client:542:22) at Socket.emit (node:events:520:28) at addChunk (node:internal/streams/readable:559:12) at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) at Readable.push (node:internal/streams/readable:390:5) at TCP.onStreamRead (node:internal/stream_base_commons:191:23) Emitted 'error' event on ClientRequest instance at: at Socket.socketOnData (node:_http_client:551:9) at Socket.emit (node:events:520:28) [... lines matching original stack trace ...] at TCP.onStreamRead (node:internal/stream_base_commons:191:23) { bytesParsed: 109, code: 'HPE_INVALID_CONSTANT', reason: 'Expected HTTP/', rawPacket: Buffer(119) [Uint8Array] [ 72, 84, 84, 80, 47, 49, 46, 49, 32, 50, 48, 48, 32, 79, 75, 13, 10, 75, 101, 101, 112, 45, 65, 108, 105, 118, 101, 58, 32, 116, 105, 109, 101, 111, 117, 116, 61, 49, 13, 10, 67, 111, 110, 110, 101, 99, 116, 105, 111, 110, 58, 32, 107, 101, 101, 112, 45, 97, 108, 105, 118, 101, 13, 10, 84, 114, 97, 110, 115, 102, 101, 114, 45, 69, 110, 99, 111, 100, 105, 110, 103, 58, 32, 99, 104, 117, 110, 107, 101, 100, 13, 10, 13, 10, 53, 13, 10, 104, 101, 108, ... 19 more items ] } Node.js v23.0.0-pre Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http-content-length.js
test-linux: test/parallel/test-http-content-length-mismatch.js#L1
--- stderr --- node:events:498 throw er; // Unhandled 'error' event ^ Error: Parse Error: Expected HTTP/ at Socket.socketOnData (node:_http_client:542:22) at Socket.emit (node:events:520:28) at addChunk (node:internal/streams/readable:559:12) at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) at Readable.push (node:internal/streams/readable:390:5) at TCP.onStreamRead (node:internal/stream_base_commons:191:23) Emitted 'error' event on ClientRequest instance at: at Socket.socketOnData (node:_http_client:551:9) at Socket.emit (node:events:520:28) [... lines matching original stack trace ...] at TCP.onStreamRead (node:internal/stream_base_commons:191:23) { bytesParsed: 148, code: 'HPE_INVALID_CONSTANT', reason: 'Expected HTTP/', rawPacket: Buffer(159) [Uint8Array] [ 72, 84, 84, 80, 47, 49, 46, 49, 32, 50, 48, 48, 32, 79, 75, 13, 10, 68, 97, 116, 101, 58, 32, 83, 117, 110, 44, 32, 49, 50, 32, 77, 97, 121, 32, 50, 48, 50, 52, 32, 49, 48, 58, 53, 55, 58, 49, 50, 32, 71, 77, 84, 13, 10, 67, 111, 110, 110, 101, 99, 116, 105, 111, 110, 58, 32, 107, 101, 101, 112, 45, 97, 108, 105, 118, 101, 13, 10, 75, 101, 101, 112, 45, 65, 108, 105, 118, 101, 58, 32, 116, 105, 109, 101, 111, 117, 116, 61, 53, 13, ... 59 more items ] } Node.js v23.0.0-pre Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http-content-length-mismatch.js
test-linux: test/parallel/test-http-destroyed-socket-write2.js#L73
--- stderr --- node:assert:126 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: 2 !== 0 at ClientRequest.<anonymous> (/home/runner/work/node/node/test/parallel/test-http-destroyed-socket-write2.js:73:12) at ClientRequest.<anonymous> (/home/runner/work/node/node/test/common/index.js:470:15) at ClientRequest.emit (node:events:520:28) at Socket.socketErrorListener (node:_http_client:502:9) at Socket.emit (node:events:520:28) at emitErrorNT (node:internal/streams/destroy:170:8) at emitErrorCloseNT (node:internal/streams/destroy:129:3) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) { generatedMessage: true, code: 'ERR_ASSERTION', actual: 2, expected: 0, operator: 'strictEqual' } Node.js v23.0.0-pre Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http-destroyed-socket-write2.js
test-linux: test/parallel/test-http-outgoing-finish.js#L1
--- stderr --- ClientRequest finish event ClientRequest endCb ServerResponse finish event ServerResponse endCb node:events:498 throw er; // Unhandled 'error' event ^ Error: Parse Error: Expected HTTP/ at Socket.socketOnData (node:_http_client:542:22) at Socket.emit (node:events:520:28) at addChunk (node:internal/streams/readable:559:12) at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) at Readable.push (node:internal/streams/readable:390:5) at TCP.onStreamRead (node:internal/stream_base_commons:191:23) Emitted 'error' event on ClientRequest instance at: at Socket.socketOnData (node:_http_client:551:9) at Socket.emit (node:events:520:28) [... lines matching original stack trace ...] at TCP.onStreamRead (node:internal/stream_base_commons:191:23) { bytesParsed: 16528, code: 'HPE_INVALID_CONSTANT', reason: 'Expected HTTP/', rawPacket: Buffer(65536) [Uint8Array] [ 72, 84, 84, 80, 47, 49, 46, 49, 32, 50, 48, 48, 32, 79, 75, 13, 10, 68, 97, 116, 101, 58, 32, 83, 117, 110, 44, 32, 49, 50, 32, 77, 97, 121, 32, 50, 48, 50, 52, 32, 49, 48, 58, 53, 55, 58, 50, 55, 32, 71, 77, 84, 13, 10, 67, 111, 110, 110, 101, 99, 116, 105, 111, 110, 58, 32, 107, 101, 101, 112, 45, 97, 108, 105, 118, 101, 13, 10, 75, 101, 101, 112, 45, 65, 108, 105, 118, 101, 58, 32, 116, 105, 109, 101, 111, 117, 116, 61, 53, 13, ... 65436 more items ] } Node.js v23.0.0-pre --- stdout --- ok - ClientRequest finishEvent ok - ClientRequest endCb ok - ServerResponse finishEvent ok - ServerResponse endCb Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http-outgoing-finish.js
test-linux: test/parallel/test-http-outgoing-message-write-callback.js#L37
--- stderr --- node:assert:126 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal: + actual - expected [ 'a', + '', + Buffer(0) [Uint8Array] [] - 'b', - '', - Buffer(0) [Uint8Array] [], - 'c' ] at ServerResponse.<anonymous> (/home/runner/work/node/node/test/parallel/test-http-outgoing-message-write-callback.js:37:12) at ServerResponse.<anonymous> (/home/runner/work/node/node/test/common/index.js:470:15) at Object.onceWrapper (node:events:634:28) at ServerResponse.emit (node:events:520:28) at onFinish (node:_http_outgoing:1081:10) at afterWrite (node:internal/streams/writable:701:5) at afterWriteTick (node:internal/streams/writable:687:10) at process.processTicksAndRejections (node:internal/process/task_queues:81:21) { generatedMessage: true, code: 'ERR_ASSERTION', actual: [ 'a', '', Buffer(0) [Uint8Array] [] ], expected: [ 'a', 'b', '', Buffer(0) [Uint8Array] [], 'c' ], operator: 'deepStrictEqual' } Node.js v23.0.0-pre Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http-outgoing-message-write-callback.js
test-linux: test/parallel/test-http-outgoing-properties.js#L27
--- stderr --- node:assert:126 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: 134 !== 139 at Server.<anonymous> (/home/runner/work/node/node/test/parallel/test-http-outgoing-properties.js:27:12) at Server.<anonymous> (/home/runner/work/node/node/test/common/index.js:470:15) at Server.emit (node:events:520:28) at parserOnIncoming (node:_http_server:1149:12) at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17) { generatedMessage: true, code: 'ERR_ASSERTION', actual: 134, expected: 139, operator: 'strictEqual' } Node.js v23.0.0-pre Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http-outgoing-properties.js