test_runner: pass noop fn when test marked as todo

nodejs · Jan 10, 2024 · 0684d04 · 0684d04
1 parent e0b159e
commit 0684d04
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 27 deletions.
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -296,7 +296,7 @@ class Test extends AsyncResource {
       skip = '\'only\' option not set';
     }
 
-    if (skip) {
+    if (skip || todo) {
       fn = noop;
     }
 

diff --git a/test/fixtures/test-runner/output/describe_it.snapshot b/test/fixtures/test-runner/output/describe_it.snapshot
@@ -10,38 +10,14 @@ ok 2 - sync pass todo with message # TODO this is a passing todo
   duration_ms: *
   ...
 # Subtest: sync todo
-not ok 3 - sync todo # TODO
+ok 3 - sync todo # TODO
   ---
   duration_ms: *
-  location: '/test/fixtures/test-runner/output/describe_it.js:(LINE):4'
-  failureType: 'testCodeFailure'
-  error: 'should not count as a failure'
-  code: 'ERR_TEST_FAILURE'
-  stack: |-
-    *
-    *
-    *
-    *
-    *
-    *
-    *
   ...
 # Subtest: sync todo with message
-not ok 4 - sync todo with message # TODO this is a failing todo
+ok 4 - sync todo with message # TODO this is a failing todo
   ---
   duration_ms: *
-  location: '/test/fixtures/test-runner/output/describe_it.js:(LINE):1'
-  failureType: 'testCodeFailure'
-  error: 'should not count as a failure'
-  code: 'ERR_TEST_FAILURE'
-  stack: |-
-    *
-    *
-    *
-    *
-    *
-    *
-    *
   ...
 # Subtest: sync skip pass
 ok 5 - sync skip pass # SKIP