fix: default option accepts undefined as value

nodejs · Sep 24, 2022 · 0a210f3 · 0a210f3
1 parent 5d71d14
commit 0a210f3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/lib/internal/util/parse_args/parse_args.js b/lib/internal/util/parse_args/parse_args.js
@@ -331,8 +331,8 @@ const parseArgs = (config = kEmptyObject) => {
         validateBoolean(multipleOption, `options.${longOption}.multiple`);
       }
 
-      if (ObjectHasOwn(optionConfig, 'default')) {
-        const defaultValue = objectGetOwn(optionConfig, 'default');
+      const defaultValue = objectGetOwn(optionConfig, 'default');
+      if (defaultValue !== undefined) {
         if (optionType === 'string' && !multipleOption) {
           validateString(defaultValue, `options.${longOption}.default`);
         } else if (optionType === 'string' && multipleOption) {

diff --git a/test/parallel/test-parse-args.mjs b/test/parallel/test-parse-args.mjs
@@ -833,6 +833,19 @@ test('default must be a boolean when option type is boolean', () => {
   );
 });
 
+test('default must accept undefined value', () => {
+  const args = [];
+  const options = { alpha: { type: 'boolean', default: undefined } };
+  const result = parseArgs({ args, options });
+  const expected = {
+    values: {
+      __proto__: null,
+    },
+    positionals: []
+  };
+  assert.deepStrictEqual(result, expected);
+});
+
 test('default must be a boolean array when option type is boolean and multiple', () => {
   const args = [];
   const options = { alpha: { type: 'boolean', multiple: true, default: 'not an array' } };