url: fix url spec compliance issues

nodejs · Feb 7, 2023 · 0d8b53a · 0d8b53a
1 parent bed28f2
commit 0d8b53a
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -153,6 +153,7 @@ class URLContext {
   hash = '';
   hasHost = false;
   hasOpaquePath = false;
+  hasHash = false;
 }
 
 function isURLSearchParams(self) {
@@ -628,7 +629,7 @@ class URL {
 
   #onParseComplete = (href, origin, protocol, host, hostname, pathname,
                       search, username, password, port, hash, hasHost,
-                      hasOpaquePath) => {
+                      hasOpaquePath, hasHash) => {
     const ctx = this[context];
     ctx.href = href;
     ctx.origin = origin;
@@ -644,6 +645,7 @@ class URL {
     // TODO(@anonrig): Remove hasHost and hasOpaquePath when kFormat is removed.
     ctx.hasHost = hasHost;
     ctx.hasOpaquePath = hasOpaquePath;
+    ctx.hasHash = hasHash;
     if (!this[searchParams]) { // Invoked from URL constructor
       this[searchParams] = new URLSearchParams();
       this[searchParams][context] = this;
@@ -864,6 +866,11 @@ function update(url, params) {
     ctx.search = '?' + serializedParams;
   } else {
     ctx.search = '';
+
+    // Potentially strip trailing spaces from an opaque path
+    if (ctx.hasOpaquePath && !ctx.hasHash) {
+      ctx.pathname = ctx.pathname.trimEnd();
+    }
   }
   ctx.href = constructHref(ctx);
 }

diff --git a/src/node_url.cc b/src/node_url.cc
@@ -62,6 +62,7 @@ void SetArgs(Environment* env, Local<Value> argv[12], const ada::result& url) {
   argv[10] = Utf8String(isolate, url->get_hash());
   argv[11] = Boolean::New(isolate, url->host.has_value());
   argv[12] = Boolean::New(isolate, url->has_opaque_path);
+  argv[13] = Boolean::New(isolate, url->fragment.has_value());
 }
 
 void Parse(const FunctionCallbackInfo<Value>& args) {
@@ -109,6 +110,7 @@ void Parse(const FunctionCallbackInfo<Value>& args) {
       undef,
       undef,
       undef,
+      undef,
   };
   SetArgs(env, argv, out);
   USE(success_callback_->Call(
@@ -260,6 +262,7 @@ void UpdateUrl(const FunctionCallbackInfo<Value>& args) {
       undef,
       undef,
       undef,
+      undef,
   };
   SetArgs(env, argv, out);
   USE(success_callback_->Call(

diff --git a/test/parallel/test-whatwg-url-custom-inspect.js b/test/parallel/test-whatwg-url-custom-inspect.js
@@ -58,7 +58,8 @@ assert.strictEqual(
     port: '8080',
     hash: '#hash',
     hasHost: true,
-    hasOpaquePath: false
+    hasOpaquePath: false,
+    hasHash: true
   }
 }`);
 

diff --git a/test/wpt/status/url.json b/test/wpt/status/url.json
@@ -7,7 +7,13 @@
     "skip": "TODO: port from .window.js"
   },
   "historical.any.js": {
-    "requires": ["small-icu"]
+    "requires": ["small-icu"],
+    "fail": {
+      "expected": [
+        "URL: no structured serialize/deserialize support",
+        "URLSearchParams: no structured serialize/deserialize support"
+      ]
+    }
   },
   "urlencoded-parser.any.js": {
     "requires": ["small-icu"]