fs: allow no-params fsPromises fileHandle read

allow no-params read for fsPromises fileHandle read
nodejs · Apr 18, 2021 · 16e4d5a · 16e4d5a
1 parent bc31dc0
commit 16e4d5a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/doc/api/fs.md b/doc/api/fs.md
@@ -285,7 +285,7 @@ Reads data from the file and stores that in the given buffer.
 If the file is not modified concurrently, the end-of-file is reached when the
 number of bytes read is zero.
 
-#### `filehandle.read(options)`
+#### `filehandle.read([options])`
 <!-- YAML
 added:
  - v13.11.0

diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -400,6 +400,9 @@ async function open(path, flags, mode) {
 async function read(handle, bufferOrOptions, offset, length, position) {
   let buffer = bufferOrOptions;
   if (!isArrayBufferView(buffer)) {
+    if (bufferOrOptions === undefined) {
+      bufferOrOptions = {};
+    }
     if (bufferOrOptions.buffer) {
       buffer = bufferOrOptions.buffer;
       validateBuffer(buffer);

diff --git a/test/parallel/test-fs-promises-file-handle-read.js b/test/parallel/test-fs-promises-file-handle-read.js
@@ -61,6 +61,12 @@ async function validateLargeRead(options) {
   assert.strictEqual(readHandle.bytesRead, 0);
 }
 
+async function validateReadNoParams() {
+  const filePath = fixtures.path('x.txt');
+  const fileHandle = await open(filePath, 'r');
+  assert.doesNotReject(fileHandle.read());
+}
+
 
 (async function() {
   tmpdir.refresh();
@@ -70,4 +76,5 @@ async function validateLargeRead(options) {
   await validateRead('', 'read-empty-file-conf', { useConf: true });
   await validateLargeRead({ useConf: false });
   await validateLargeRead({ useConf: true });
+  await validateReadNoParams();
 })().then(common.mustCall());