Skip to content

Commit

Permalink
src: bump NODE_MODULE_VERSION for extraorinary ABI breakage
Browse files Browse the repository at this point in the history
Bumping NODE_MODULE_VERSION for v20.x from 115 to 119 for extraordinary
ABI breakage in order to fix the long-standing memory issues
surrounding vm.Script/vm.*Module blocking users from upgrading from
v16.x.
  • Loading branch information
joyeecheung committed Sep 26, 2023
1 parent 96c706e commit 245596d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions doc/abi_version_registry.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"NODE_MODULE_VERSION": [
{ "modules": 119,"runtime": "node", "variant": "v8_11.3", "versions": "20.REPLACEME" },
{ "modules": 118,"runtime": "electron", "variant": "electron", "versions": "27" },
{ "modules": 117,"runtime": "electron", "variant": "electron", "versions": "26" },
{ "modules": 116,"runtime": "electron", "variant": "electron", "versions": "25" },
Expand Down
2 changes: 1 addition & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
* version matching should open a pull request to reserve a number in this
* registry.
*/
#define NODE_MODULE_VERSION 115
#define NODE_MODULE_VERSION 119

// The NAPI_VERSION provided by this version of the runtime. This is the version
// which the Node binary being built supports.
Expand Down

0 comments on commit 245596d

Please sign in to comment.