events: remove srcElement from Event

`srcElement` is deprecated. So remove it from Event. Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/srcElement
nodejs · Jan 4, 2023 · 28415d3 · 28415d3
1 parent 57048ac
commit 28415d3
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 24 deletions.
diff --git a/doc/api/events.md b/doc/api/events.md
@@ -1846,16 +1846,6 @@ added: v14.5.0
 
 This is not used in Node.js and is provided purely for completeness.
 
-#### `event.srcElement`
-
-<!-- YAML
-added: v14.5.0
--->
-
-* Type: {EventTarget} The `EventTarget` dispatching the event.
-
-Alias for `event.target`.
-
 #### `event.stopImmediatePropagation()`
 
 <!-- YAML

diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -172,15 +172,6 @@ class Event {
     return this[kTarget];
   }
 
-  /**
-   * @type {EventTarget}
-   */
-  get srcElement() {
-    if (!isEvent(this))
-      throw new ERR_INVALID_THIS('Event');
-    return this[kTarget];
-  }
-
   /**
    * @type {string}
    */
@@ -311,7 +302,6 @@ ObjectDefineProperties(
     preventDefault: kEnumerableProperty,
     target: kEnumerableProperty,
     currentTarget: kEnumerableProperty,
-    srcElement: kEnumerableProperty,
     type: kEnumerableProperty,
     cancelable: kEnumerableProperty,
     defaultPrevented: kEnumerableProperty,

diff --git a/test/parallel/test-events-customevent.js b/test/parallel/test-events-customevent.js
@@ -289,7 +289,6 @@ const { Event, EventTarget, CustomEvent } = require('internal/event_target');
     common.mustCall((event) => {
       strictEqual(event.target, target);
       strictEqual(event.currentTarget, target);
-      strictEqual(event.srcElement, target);
       strictEqual(event.detail, obj);
     }),
   );

diff --git a/test/parallel/test-eventtarget-brandcheck.js b/test/parallel/test-eventtarget-brandcheck.js
@@ -14,7 +14,6 @@ const {
 [
   'target',
   'currentTarget',
-  'srcElement',
   'type',
   'cancelable',
   'defaultPrevented',
@@ -44,7 +43,6 @@ const {
 [
   'target',
   'currentTarget',
-  'srcElement',
   'type',
   'cancelable',
   'defaultPrevented',

diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -377,7 +377,6 @@ let asyncTest = Promise.resolve();
   target.addEventListener('foo', common.mustCall((event) => {
     strictEqual(event.target, target);
     strictEqual(event.currentTarget, target);
-    strictEqual(event.srcElement, target);
   }));
   target.dispatchEvent(event);
 }