Skip to content

Commit

Permalink
doc: revise tools/icu/README.md
Browse files Browse the repository at this point in the history
* Simplify introductory sentence.
* Remove some passive voice.
* Make style in bulleted list a little more consistent.
* Remove superfluous list entry.

PR-URL: #32136
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
Trott committed Mar 9, 2020
1 parent 41ac192 commit 2a7d662
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions tools/icu/README.md
@@ -1,9 +1,8 @@
# Notes about the `tools/icu` subdirectory

This directory contains tools, data, and information about the
International Components for Unicode integration. [ICU][] is used
both by V8 and also by
Node.js itself to provide internationalization functionality.
This directory contains tools and information about the
[International Components for Unicode][ICU] (ICU) integration.
Both V8 and Node.js use ICU to provide internationalization functionality.

* `patches/` are one-off patches, actually entire source file replacements,
organized by ICU version number.
Expand All @@ -15,9 +14,8 @@ Node.js itself to provide internationalization functionality.
is invoked. It builds against the `pkg-config` located ICU.
* `iculslocs.cc` is source for the `iculslocs` utility, invoked by `icutrim.py`
as part of repackaging. Not used separately. See source for more details.
* `no-op.cc` — empty function to convince gyp to use a C++ compiler.
* `README.md` — you are here
* `shrink-icu-src.py` — this is used during upgrade (see guide below)
* `no-op.cc` contains an empty function to convince gyp to use a C++ compiler.
* `shrink-icu-src.py` is used during upgrade (see guide below).

Note:
> The files in this directory were written for the Node.js v0.12 effort.
Expand Down

0 comments on commit 2a7d662

Please sign in to comment.