Skip to content

Commit

Permalink
test: remove message from strictEqual assertions
Browse files Browse the repository at this point in the history
When an AssertionError happens, the value of headers['set-cookie']
is not reported. That information is useful for debugging.
Hence removed the value passed as the message in deepStrictEqual
assertions of test/parallel/test-http2-cookies.js

PR-URL: #20174
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
bryancr89 authored and Trott committed Apr 21, 2018
1 parent d96075c commit 2a88f02
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test/parallel/test-http2-cookies.js
Expand Up @@ -48,8 +48,7 @@ server.on('listening', common.mustCall(() => {

req.on('response', common.mustCall((headers) => {
assert(Array.isArray(headers['set-cookie']));
assert.deepStrictEqual(headers['set-cookie'], setCookie,
'set-cookie header does not match');

This comment has been minimized.

Copy link
@tommytime209

tommytime209 May 26, 2018

trenove

assert.deepStrictEqual(headers['set-cookie'], setCookie);
}));

req.on('end', common.mustCall(() => {
Expand Down

0 comments on commit 2a88f02

Please sign in to comment.